admin/config.php
Avoid variables with short names like $i. Configured minimum length is 3. Open
Open
$i = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 41 and the first side effect is on line 32. Open
Open
<?php- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
Open
$ele = new \XoopsFormRadioYN($title, $option[$i]['conf_name'], $option[$i]['conf_value'], _YES, _NO);- Exclude checks
Line exceeds 120 characters; contains 172 characters Open
Open
$sql = 'UPDATE ' . $xoopsDB->prefix('xfguestbook_config') . " SET conf_value='" . ${$option[$i]['conf_name']} . '\' WHERE conf_id=' . $option[$i]['conf_id'];- Exclude checks
Line exceeds 120 characters; contains 199 characters Open
Open
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Exclude checks
Line exceeds 120 characters; contains 240 characters Open
Open
|| '' === constant($option[$i]['conf_desc'])) ? constant($option[$i]['conf_title']) : constant($option[$i]['conf_title']) . '<br><br><span style="font-weight:normal;">' . constant($option[$i]['conf_desc']) . '</span>';- Exclude checks
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $arr_conf is not named in camelCase. Open
Open
function getOptions4Admin($cat = 2)
{
global $xoopsDB;
$arr_conf = [];
$sql = 'SELECT conf_id, conf_name, conf_value, conf_title, conf_formtype, conf_desc FROM ' . $xoopsDB->prefix('xfguestbook_config') . ' WHERE conf_cat=' . $cat . ' ORDER BY conf_order ASC';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}