flagUpload accesses the super-global variable $_FILES. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
flagUpload accesses the super-global variable $_FILES. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
flagUpload accesses the super-global variable $_POST. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
flagUpload accesses the super-global variable $_FILES. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
flagUpload accesses the super-global variable $_FILES. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
File country_manager.php
has 302 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
//
// ------------------------------------------------------------------------ //
// XF Guestbook //
// ------------------------------------------------------------------------- //
Function flagUpload
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method countryShow
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
Method flagUpload
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
Function countryShow
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '88', column '31'). Open
$uploader = new \XoopsMediaUploader($photos_dir, $array_allowed_mimetypes, $maxsize, $maxwidth, $maxheight);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '137', column '33'). Open
$buttonTray->addElement(new \XoopsFormButton('', 'post', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '196', column '23'). Open
$buttonTray = new \XoopsFormElementTray('', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '130', column '31'). Open
$flagform->addElement(new \XoopsFormLabel('', $flag_desc));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '197', column '33'). Open
$buttonTray->addElement(new \XoopsFormButton('', 'save', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '199', column '37'). Open
$buttonTray->addElement(new \XoopsFormHidden('country_id', $country_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '120', column '21'). Open
$flagform = new \XoopsThemeForm(AM_XFGUESTBOOK_SUBMITFLAG, 'op', xoops_getenv('SCRIPT_NAME'), 'post', true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '136', column '23'). Open
$buttonTray = new \XoopsFormElementTray('', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '139', column '33'). Open
$buttonTray->addElement(new \XoopsFormHidden('op', 'flagUpload'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '189', column '22'). Open
$text_code = new \XoopsFormText(AM_XFGUESTBOOK_FLAGCODE, 'country_code', 5, 5, $country_code);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '132', column '21'). Open
$img_text = new \XoopsFormFile(AM_XFGUESTBOOK_ADDIMG, 'photo', 30000);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '201', column '33'). Open
$buttonTray->addElement(new \XoopsFormHidden('op', 'countrySave'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '138', column '33'). Open
$buttonTray->addElement(new \XoopsFormHidden('country_code', $country_code));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '126', column '25'). Open
$img_flag = new \XoopsFormLabel('', '<br>' . $flag_img . '<br>');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '184', column '29'). Open
$sform = new \XoopsThemeForm(AM_XFGUESTBOOK_ADDCOUNTRY, 'op', xoops_getenv('SCRIPT_NAME'), 'post', true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '355', column '24'). Open
$pagenav = new \XoopsPageNav($totalcount, $limit, $start, 'start', 'action=' . $action);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '194', column '28'). Open
$sform->addElement(new \XoopsFormText(AM_XFGUESTBOOK_FLAGNAME, 'country_name', 50, 50, $country_name), true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '179', column '29'). Open
$sform = new \XoopsThemeForm(AM_XFGUESTBOOK_MODCOUNTRY, 'op', xoops_getenv('SCRIPT_NAME'), 'post', true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\Xmf\Request' in method 'flagDel'. Open
$ok = Request::getInt('ok', 0, 'POST');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Helper' in method 'flagUpload'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method flagUpload uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
redirect_header('country_manager.php', 2, $uploader->getErrors());
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Xmf\Module\Admin' in method 'flagDel'. Open
$adminObject = Admin::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Helper' in method 'flagDel'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method flagDel uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
xoops_cp_header();
$adminObject = Admin::getInstance();
$adminObject->displayNavigation(basename(__FILE__));
xoops_confirm(['op' => 'flagDel', 'country_code' => $country_code, 'ok' => 1], 'country_manager.php', AM_XFGUESTBOOK_CONFDELFLAG);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'countryForm'. Open
$arr_country = Xfguestbook\Utility::getCountry('country_id=' . $country_id, 0, 0);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Xmf\Request' in method 'countryDel'. Open
$ok = Request::getInt('ok', 0, 'POST');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\MyTextSanitizer' in method 'countrySave'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method countryShow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
echo '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method countryForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$sform = new \XoopsThemeForm(AM_XFGUESTBOOK_ADDCOUNTRY, 'op', xoops_getenv('SCRIPT_NAME'), 'post', true);
$country_code = '';
$country_name = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method countryShow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$all_country['flag_img'] = "<img src='" . XOOPS_URL . "/images/blank.gif'>";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Xmf\Module\Admin' in method 'countryDel'. Open
$adminObject = Admin::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method flagUpload uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
redirect_header('country_manager.php?op=flagForm&country_code=' . $country_code, 2, MD_XFGUESTBOOK_NOIMGSELECTED);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\XoopsModules\Xfguestbook\Helper' in method 'flagForm'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Helper' in method 'countryDel'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Helper' in method 'countryShow'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'countryShow'. Open
$arr_country = Xfguestbook\Utility::getCountry('', $limit, $start);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method countrySave uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$country_id = $xoopsDB->genId('country_id_seq');
$sql = sprintf("INSERT INTO `%s` (country_id, country_code, country_name) VALUES (%s, '%s', '%s')", $xoopsDB->prefix('xfguestbook_country'), $country_id, $country_code, $country_name);
$xoopsDB->query($sql);
$messagesent = AM_XFGUESTBOOK_COUNTRY_ADDED;
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'countryShow'. Open
$scount = count(Xfguestbook\Utility::getCountry('', $limit, 0));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method countryDel uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
xoops_cp_header();
$adminObject = Admin::getInstance();
$adminObject->displayNavigation(basename(__FILE__));
xoops_confirm(['op' => 'countryDel', 'country_id' => $country_id, 'ok' => 1], 'country_manager.php', AM_XFGUESTBOOK_CONFDELCOUNTRY);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method countrySave uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$sql = sprintf("SELECT COUNT(*) FROM %s WHERE country_code = '%s'", $xoopsDB->prefix('xfguestbook_country'), $country_code);
[$count] = $xoopsDB->fetchRow($xoopsDB->query($sql));
if ($count > 0) {
$messagesent = '<span style="color: #FF0000; ">' . AM_XFGUESTBOOK_COUNTRY_EXIST . '</span>';
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\MyTextSanitizer' in method 'countryShow'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'countryDel'. Open
$arr_country = Xfguestbook\Utility::getCountry('country_id=' . $country_id, 0, 0);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'countryShow'. Open
$totalcount = count(Xfguestbook\Utility::getCountry('', 0, 0));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$result'. Open
$result = $xoopsDB->query($sql);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The function flagUpload() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused local variables such as '$myts'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$myts'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$action'. Open
global $xoopsDB, $action;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Similar blocks of code found in 2 locations. Consider refactoring. Open
function xfgb_getCountry($criteria = null, $limit = 0, $start = 0)
{
global $xoopsDB, $action;
$ret = [];
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 120.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $array_allowed_mimetypes. Keep variable name length under 20. Open
$array_allowed_mimetypes = ['image/' . $format];
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
The parameter $country_code is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $country_code is not named in camelCase. Open
function flagDel($country_code)
{
global $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $country_id is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $ok. Configured minimum length is 3. Open
$ok = Request::getInt('ok', 0, 'POST');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $country_code is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $ok. Configured minimum length is 3. Open
$ok = Request::getInt('ok', 0, 'POST');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $country_id is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $country_code is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $country_name is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 70 and the first side effect is on line 33. Open
<?php
- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
xoops_confirm(['op' => 'countryDel', 'country_id' => $country_id, 'ok' => 1], 'country_manager.php', AM_XFGUESTBOOK_CONFDELCOUNTRY);
- Exclude checks
Line exceeds 120 characters; contains 196 characters Open
$all_country['flag_action'] .= " <a href='country_manager.php?op=flagDel&country_code=" . $arr_country[$i]['country_code'] . '\'><img src=\'' . $pathIcon16 . "/delete.png'></a>";
- Exclude checks
Line exceeds 120 characters; contains 168 characters Open
$flag = '/modules/' . $xoopsModule->dirname() . '/assets/images/flags/' . $helper->getConfig('flagdir') . '/' . $arr_country[0]['country_code'] . '.gif';
- Exclude checks
Line exceeds 120 characters; contains 143 characters Open
$flag = '/modules/' . $xoopsModule->dirname() . '/assets/images/flags/' . $helper->getConfig('flagdir') . '/' . $country_code . '.gif';
- Exclude checks
Line exceeds 120 characters; contains 138 characters Open
xoops_confirm(['op' => 'flagDel', 'country_code' => $country_code, 'ok' => 1], 'country_manager.php', AM_XFGUESTBOOK_CONFDELFLAG);
- Exclude checks
Line exceeds 120 characters; contains 203 characters Open
$sql = sprintf("INSERT INTO `%s` (country_id, country_code, country_name) VALUES (%s, '%s', '%s')", $xoopsDB->prefix('xfguestbook_country'), $country_id, $country_code, $country_name);
- Exclude checks
Line exceeds 120 characters; contains 171 characters Open
<table width='100%' cellspacing='1' cellpadding='2' border='0' style='border-left: 1px solid #c0c0c0; border-top: 1px solid #c0c0c0; border-right: 1px solid #c0c0c0;'>
- Exclude checks
Line exceeds 120 characters; contains 160 characters Open
<td><span style='font-weight: bold; font-size: 12px; font-variant: small-caps;'>" . AM_XFGUESTBOOK_DISPCOUNTRY . ' : ' . $totalcount . "</span></td>
- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
$photos_dir = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/assets/images/flags/' . $helper->getConfig('flagdir');
- Exclude checks
Line exceeds 120 characters; contains 122 characters Open
$uploader = new \XoopsMediaUploader($photos_dir, $array_allowed_mimetypes, $maxsize, $maxwidth, $maxheight);
- Exclude checks
Line exceeds 120 characters; contains 187 characters Open
$all_country['msg_action'] = "<a href='country_manager.php?op=countryEdit&country_id=" . $arr_country[$i]['country_id'] . '\'><img src=\'' . $pathIcon16 . "/edit.png'></a>";
- Exclude checks
Line exceeds 120 characters; contains 169 characters Open
$flag = '/modules/' . $xoopsModule->dirname() . '/assets/images/flags/' . $helper->getConfig('flagdir') . '/' . $arr_country[$i]['country_code'] . '.gif';
- Exclude checks
Line exceeds 120 characters; contains 139 characters Open
$flag = '/modules/' . $xoopsModule->dirname() . '/assets/images/flags/' . $helper->getConfig('flagdir') . '/' . $country_code . '.gif';
- Exclude checks
Line exceeds 120 characters; contains 135 characters Open
$sql = 'UPDATE ' . $xoopsDB->prefix('xfguestbook_country') . " SET country_code='$country_code', country_name='$country_name'";
- Exclude checks
Line exceeds 120 characters; contains 133 characters Open
$sql = sprintf("SELECT COUNT(*) FROM %s WHERE country_code = '%s'", $xoopsDB->prefix('xfguestbook_country'), $country_code);
- Exclude checks
Line exceeds 120 characters; contains 187 characters Open
$all_country['flag_action'] = "<a href='country_manager.php?op=flagForm&country_code=" . $arr_country[$i]['country_code'] . '\'><img src=\'' . $pathIcon16 . "/add.png'></a>";
- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
redirect_header('country_manager.php?op=flagForm&country_code=' . $country_code, 2, MD_XFGUESTBOOK_NOIMGSELECTED);
- Exclude checks
Line exceeds 120 characters; contains 195 characters Open
$all_country['msg_action'] .= " <a href='country_manager.php?op=countryDel&country_id=" . $arr_country[$i]['country_id'] . '\'><img src=\'' . $pathIcon16 . "/delete.png'></a>";
- Exclude checks
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $flag_desc is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_name is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tmp_name is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_name is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $array_allowed_mimetypes is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $array_allowed_mimetypes is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $text_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $flag_img is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_flag is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $text_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_flag is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_text is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $flag_img is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_text is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $photos_dir is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_name is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tmp_name is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $flag_desc is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_text is not named in camelCase. Open
function flagForm($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_name is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $text_code is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagDel($country_code)
{
global $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tmp_name is not named in camelCase. Open
function flagUpload($country_code)
{
global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function flagDel($country_code)
{
global $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryForm($country_id = null)
{
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
if ($country_id) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_code is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_id is not named in camelCase. Open
function countryDel($country_id)
{
global $xoopsDB, $xoopsModule;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $country_name is not named in camelCase. Open
function countrySave($country_id, $country_code, $country_name)
{
global $xoopsDB;
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $arr_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $all_country is not named in camelCase. Open
function countryShow()
{
global $action, $start, $xoopsModule, $pathIcon16;
/** @var Helper $helper */
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}