XoopsModules25x/xfguestbook

View on GitHub
admin/main.php

Summary

Maintainability
D
2 days
Test Coverage

delete accesses the super-global variable $_SERVER.
Open

function delete()
{
    global $msgHandler, $xoopsModule;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_POST.
Open

function delete()
{
    global $msgHandler, $xoopsModule;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_POST.
Open

function delete()
{
    global $msgHandler, $xoopsModule;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_POST.
Open

function delete()
{
    global $msgHandler, $xoopsModule;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_POST.
Open

function delete()
{
    global $msgHandler, $xoopsModule;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

show accesses the super-global variable $_SERVER.
Open

function show()
{
    global $msgHandler, $xoopsModule, $pathIcon16;
    $pick              = Request::getInt('pick', 0, 'GET');
    $start             = Request::getInt('start', 0, 'GET');
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

approve accesses the super-global variable $_POST.
Open

function approve()
{
    global $msgHandler;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

banish accesses the super-global variable $_POST.
Open

function banish()
{
    global $msgHandler, $xoopsDB;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

approve accesses the super-global variable $_POST.
Open

function approve()
{
    global $msgHandler;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

banish accesses the super-global variable $_POST.
Open

function banish()
{
    global $msgHandler, $xoopsDB;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

banish accesses the super-global variable $_POST.
Open

function banish()
{
    global $msgHandler, $xoopsDB;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

approve accesses the super-global variable $_POST.
Open

function approve()
{
    global $msgHandler;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

approve accesses the super-global variable $_SERVER.
Open

function approve()
{
    global $msgHandler;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

show accesses the super-global variable $GLOBALS.
Open

function show()
{
    global $msgHandler, $xoopsModule, $pathIcon16;
    $pick              = Request::getInt('pick', 0, 'GET');
    $start             = Request::getInt('start', 0, 'GET');
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

approve accesses the super-global variable $_POST.
Open

function approve()
{
    global $msgHandler;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

banish accesses the super-global variable $_POST.
Open

function banish()
{
    global $msgHandler, $xoopsDB;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

banish accesses the super-global variable $_SERVER.
Open

function banish()
{
    global $msgHandler, $xoopsDB;
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

show accesses the super-global variable $_SERVER.
Open

function show()
{
    global $msgHandler, $xoopsModule, $pathIcon16;
    $pick              = Request::getInt('pick', 0, 'GET');
    $start             = Request::getInt('start', 0, 'GET');
Severity: Minor
Found in admin/main.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method show has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function show()
{
    global $msgHandler, $xoopsModule, $pathIcon16;
    $pick              = Request::getInt('pick', 0, 'GET');
    $start             = Request::getInt('start', 0, 'GET');
Severity: Major
Found in admin/main.php - About 5 hrs to fix

    Function show has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function show()
    {
        global $msgHandler, $xoopsModule, $pathIcon16;
        $pick              = Request::getInt('pick', 0, 'GET');
        $start             = Request::getInt('start', 0, 'GET');
    Severity: Minor
    Found in admin/main.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File main.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    //
    //  ------------------------------------------------------------------------ //
    //             XF Guestbook                                                  //
    // ------------------------------------------------------------------------- //
    Severity: Minor
    Found in admin/main.php - About 3 hrs to fix

      Function banish has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      function banish()
      {
          global $msgHandler, $xoopsDB;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function delete has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function delete()
      {
          global $msgHandler, $xoopsModule;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function approve has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function approve()
      {
          global $msgHandler;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The function show() has 154 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      The function show() has an NPath complexity of 420. The configured NPath complexity threshold is 200.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The function show() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '147', column '35').
      Open

                  $criteria       = new \Criteria('msg_id', 0, '>');
      Severity: Minor
      Found in admin/main.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '153', column '35').
      Open

                  $criteria       = new \Criteria('moderate', '0');
      Severity: Minor
      Found in admin/main.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '159', column '35').
      Open

                  $criteria       = new \Criteria('moderate', '1');
      Severity: Minor
      Found in admin/main.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '276', column '24').
      Open

              $pagenav = new \XoopsPageNav($totalcount, $limit, $start, 'start', 'sel_status=' . $sel_status . '&sel_order=' . $sel_order);
      Severity: Minor
      Found in admin/main.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method banish uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              $messagesent = AM_XFGUESTBOOK_NOMSG;
          }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'show'.
      Open

          $badips = Xfguestbook\Utility::get_badips();
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'show'.
      Open

          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'show'.
      Open

          $pick              = Request::getInt('pick', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              echo '';
          }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Xfguestbook\Utility' in method 'banish'.
      Open

              $badips = Xfguestbook\Utility::get_badips();
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method approve uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              $messagesent = AM_XFGUESTBOOK_NOMSG;
          }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              echo "<tr ><td align='center' colspan ='10' class = 'head'><b>" . AM_XFGUESTBOOK_NOMSG . '</b></td></tr>';
          }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Xmf\Request' in method 'show'.
      Open

          $sel_status        = Request::getInt('sel_status', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'show'.
      Open

          $sel_order         = Request::getInt('sel_order', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $all_msg['message'] = $onemsg->getVar('message');
                  }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              $messagesent = AM_XFGUESTBOOK_NOMSG;
          }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $img_status .= "ic15_ok.gif'>";
                  }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsUser' in method 'show'.
      Open

                  $all_msg['user']      = ($onemsg->getVar('user_id') > 0) ? \XoopsUser::getUnameFromId($onemsg->getVar('user_id')) : $onemsg->getVar('uname');
      Severity: Minor
      Found in admin/main.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      echo $onemsg->getVar('poster_ip') . '</td>';
                  }
      Severity: Minor
      Found in admin/main.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid unused local variables such as '$pick'.
      Open

          $pick              = Request::getInt('pick', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$result'.
      Open

                      $result = $xoopsDB->query($sql);
      Severity: Minor
      Found in admin/main.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid variables with short names like $ip. Configured minimum length is 3.
      Open

                  $ip[$i] = $msg->getVar('poster_ip');
      Severity: Minor
      Found in admin/main.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 57 and the first side effect is on line 31.
      Open

      <?php
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 153 characters
      Open

          redirect_header(XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin&op=update&module=' . $xoopsModule->dirname(), 4, AM_XFGUESTBOOK_MUST_UPDATE);
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 144 characters
      Open

                      <td><span style='font-weight: bold; font-size: 12px; font-variant: small-caps;'>" . $title . ' : ' . $totalcount . "</span></td>
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 153 characters
      Open

                  $all_msg['user']      = ($onemsg->getVar('user_id') > 0) ? \XoopsUser::getUnameFromId($onemsg->getVar('user_id')) : $onemsg->getVar('uname');
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 157 characters
      Open

                  $all_msg['action']    = "<a href='main.php?op=edit&amp;msg_id=" . $onemsg->getVar('msg_id') . '\'><img src=\'' . $pathIcon16 . "/edit.png'></a>";
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 121 characters
      Open

                  $img_status           = "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/assets/images/';
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 123 characters
      Open

              echo "<td colspan='6'>" . $GLOBALS['xoopsSecurity']->getTokenHTML() . "<input type='submit' value='" . _GO . '\'>';
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 146 characters
      Open

                  echo "<td align='center' class='even'><input type='checkbox' name='msg_id[]' id='msg_id[]' value='" . $all_msg['msg_id'] . '\'></td>';
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 150 characters
      Open

                  $all_msg['title']   = "<a href='../index.php?op=show_one&msg_id=" . $onemsg->getVar('msg_id') . '\'>' . $onemsg->getVar('title') . '</a>';
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 175 characters
      Open

              <table width='100%' cellspacing='1' cellpadding='2' border='0' style='border-left: 1px solid #c0c0c0; border-top: 1px solid #c0c0c0; border-right: 1px solid #c0c0c0;'>
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 126 characters
      Open

              echo "<form name='msglist' id='list' action='" . $_SERVER['SCRIPT_NAME'] . '\' method=\'POST\' style=\'margin: 0;\'>';
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 207 characters
      Open

                      $all_msg['message'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $xoopsModule->getVar('dirname') . '/' . $onemsg->getVar('photo') . '" align = "left" hspace ="10">' . $onemsg->getVar('message');
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      Line exceeds 120 characters; contains 133 characters
      Open

              $pagenav = new \XoopsPageNav($totalcount, $limit, $start, 'start', 'sel_status=' . $sel_status . '&sel_order=' . $sel_order);
      Severity: Minor
      Found in admin/main.php by phpcodesniffer

      The variable $msg_count is not named in camelCase.
      Open

      function delete()
      {
          global $msgHandler, $xoopsModule;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_desc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_order is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option0 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option1 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $img_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option2 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_desc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function approve()
      {
          global $msgHandler;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function banish()
      {
          global $msgHandler, $xoopsDB;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_asc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option2 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_desc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $img_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function delete()
      {
          global $msgHandler, $xoopsModule;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option1 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_asc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $img_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function delete()
      {
          global $msgHandler, $xoopsModule;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function approve()
      {
          global $msgHandler;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option1 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option2 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function approve()
      {
          global $msgHandler;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_order is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $img_status is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option0 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $status_option0 is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sel_order is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function banish()
      {
          global $msgHandler, $xoopsDB;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $msg_count is not named in camelCase.
      Open

      function banish()
      {
          global $msgHandler, $xoopsDB;
          $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
          if ($msg_count > 0) {
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $all_msg is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $order_option_asc is not named in camelCase.
      Open

      function show()
      {
          global $msgHandler, $xoopsModule, $pathIcon16;
          $pick              = Request::getInt('pick', 0, 'GET');
          $start             = Request::getInt('start', 0, 'GET');
      Severity: Minor
      Found in admin/main.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status