moveDoColumns accesses the super-global variable $GLOBALS. Open
private function moveDoColumns()
{
$tableName = 'newbb_posts_text';
$srcTableName = 'newbb_posts';
if ($this->tableHandler->useTable($tableName)
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
moveDoColumns accesses the super-global variable $GLOBALS. Open
private function moveDoColumns()
{
$tableName = 'newbb_posts_text';
$srcTableName = 'newbb_posts';
if ($this->tableHandler->useTable($tableName)
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Function convertIPAddresses
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function convertIPAddresses($tableName, $columnName)
{
if ($this->tableHandler->useTable($tableName)) {
$attributes = $this->tableHandler->getColumnAttributes($tableName, $columnName);
if (false !== mb_strpos($attributes, ' int(')) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '37', column '23'). Open
throw new \RuntimeException("Class '$class' not found");
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused private methods such as 'convertIPAddresses'. Open
private function convertIPAddresses($tableName, $columnName)
{
if ($this->tableHandler->useTable($tableName)) {
$attributes = $this->tableHandler->getColumnAttributes($tableName, $columnName);
if (false !== mb_strpos($attributes, ' int(')) {
- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}
Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
Avoid unused private methods such as 'moveDoColumns'. Open
private function moveDoColumns()
{
$tableName = 'newbb_posts_text';
$srcTableName = 'newbb_posts';
if ($this->tableHandler->useTable($tableName)
- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}
Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
Avoid unused private methods such as 'changePrefix'. Open
private function changePrefix()
{
foreach ($this->renameTables as $oldName => $newName) {
if ($this->tableHandler->useTable($oldName) && !$this->tableHandler->useTable($newName)) {
$this->tableHandler->renameTable($oldName, $newName);
- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}
Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
Line exceeds 120 characters; contains 137 characters Open
$this->tableHandler->update($tableName, [$columnName => "4294967296 + $columnName"], "WHERE $columnName < 0", false);
- Exclude checks
Line exceeds 120 characters; contains 251 characters Open
$sql = "UPDATE `$updateTable` t1 INNER JOIN `$joinTable` t2 ON t1.post_id = t2.post_id \n" . "SET t1.dohtml = t2.dohtml, t1.dosmiley = t2.dosmiley, t1.doxcode = t2.doxcode\n" . ' , t1.doimage = t2.doimage, t1.dobr = t2.dobr';
- Exclude checks