Sign upLogin

XoopsModules25x/xfguestbook

View on GitHub
Star
class/Form/FormSelectCountry.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($caption, $name, $value = null, $size = 1, $nullopt = false)
Severity: Minor
Found in class/Form/FormSelectCountry.php - About 35 mins to fix

    The method __construct has a boolean flag argument $nullopt, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($caption, $name, $value = null, $size = 1, $nullopt = false)
    Severity: Minor
    Found in class/Form/FormSelectCountry.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid using static access to class '\XoopsDatabaseFactory' in method '__construct'.
    Open

            $db = \XoopsDatabaseFactory::getDatabaseConnection();
    Severity: Minor
    Found in class/Form/FormSelectCountry.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = \XoopsDatabaseFactory::getDatabaseConnection();
    Severity: Minor
    Found in class/Form/FormSelectCountry.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 34 and the first side effect is on line 29.
    Open

    <?php
    Severity: Minor
    Found in class/Form/FormSelectCountry.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

            $sql    = 'SELECT country_code, country_name FROM ' . $db->prefix('xfguestbook_country') . ' ORDER BY country_name';
    Severity: Minor
    Found in class/Form/FormSelectCountry.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status