Method xfguestbook_search has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {Method xfguestbook_search has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)Function xfguestbook_search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid assigning values to variables in if clauses and the like (line '43', column '34'). Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The parameter $user_id is not named in camelCase. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The variable $user_id is not named in camelCase. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $user_id is not named in camelCase. Open
function xfguestbook_search($queryarray, $andor, $limit, $offset, $user_id)
{
global $xoopsDB;
$sql = 'SELECT msg_id,user_id,title,post_time FROM ' . $xoopsDB->prefix('xfguestbook_msg') . ' WHERE moderate=0 ';
if (0 != $user_id) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}