Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
// Common
define('AM_XFGUESTBOOK_ALLMSG', 'All messages');
define('AM_XFGUESTBOOK_PUBMSG', 'Published messages ');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1676.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Line exceeds 120 characters; contains 131 characters Open
define('AM_XFGUESTBOOK_WARNING_UPGRADE', 'Attention, this operation will modify certain tables. <br>Please make a backup first !');
- Exclude checks
Line exceeds 120 characters; contains 134 characters Open
define('AM_XFGUESTBOOK_ERROR_FLAGS', '<span style=\'color: #FF0000; \'> Data insertion Error of %s.sql <br> Table %s deleted</span>');
- Exclude checks
Line exceeds 120 characters; contains 223 characters Open
define('AM_XFGUESTBOOK_WARNING_MSG2', "<span style='color: #FF0000; '>For Selection ' YES' you must install one<a href='" . XOOPS_URL . "/modules/xfguestbook/admin/flags_install.php'>Image Pack of (flags, ...)</a></span>");
- Exclude checks
Line exceeds 120 characters; contains 127 characters Open
define('AM_XFGUESTBOOK_CONFDELCOUNTRY', 'WARNING: Are you sure you want to delete this country ? <br>And the flag if exist ?');
- Exclude checks
Line exceeds 120 characters; contains 225 characters Open
define('AM_XFGUESTBOOK_ORPHEAN_DSC', ' This page enables you to post the images which are not attached to a message (orphan).<br> This can occur if a problem when sending a message.<br> Erase these useless images');
- Exclude checks
Line exceeds 120 characters; contains 199 characters Open
define('AM_XFGUESTBOOK_WARNING_MSG1', '<span style=\'color: #FF0000; \'> This operation will erase the contents of the table</span> %s <span style=\'color: #FF0000; \'> and replace it.</span>');
- Exclude checks