Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
// Common
define('AM_XFGUESTBOOK_ALLMSG', 'Tutti i messaggi');
define('AM_XFGUESTBOOK_PUBMSG', 'Messaggi pubblicati ');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1676.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Line exceeds 120 characters; contains 137 characters Open
define('AM_XFGUESTBOOK_ORPHEAN_DSC', ' Questa pagina ti consente di inviare le immagini che non sono allegate a un messaggio (orfane).');
- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
define('AM_XFGUESTBOOK_ERROR_FLAGS', "<span style='color: #FF0000; '> Errore inserimento dati di %s.sql <br> Tabella %s cancellata</span>");
- Exclude checks
Line exceeds 120 characters; contains 141 characters Open
define('AM_XFGUESTBOOK_CONFDELCOUNTRY', 'ATTENZIONE: Sei sicuro di voler cancellare questa località ? <br>E la bandiera se esiste ?');
- Exclude checks
Line exceeds 120 characters; contains 135 characters Open
define('AM_XFGUESTBOOK_WARNING_UPGRADE', 'Attenzione, questa operazione modificherà alcune tabelle. <br>Fai un backup prima !');
- Exclude checks
Line exceeds 120 characters; contains 229 characters Open
define('AM_XFGUESTBOOK_WARNING_MSG2', "<span style='color: #FF0000; '>Se scegli ' SI ' devi installare un<a href=\"" . XOOPS_URL . '/modules/xfguestbook/admin/flags_install.php">pacchetto immagine di (bandiere, ...)</a></span>');
- Exclude checks
Line exceeds 120 characters; contains 213 characters Open
define('AM_XFGUESTBOOK_WARNING_MSG1', "<span style='color: #FF0000; '> Questa operazione cancellerà i contenuti della tabella</span> %s <span style='color: #FF0000; '> e la sostituirà.</span>");
- Exclude checks