Sign upLogin

XoopsModules25x/xoopshp

View on GitHub
Star

Showing 586 of 586 total issues

File main.php has 598 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
//  ------------------------------------------------------------------------ //
//             --  XoopsHP Module --       Xoops e-Learning System           //
//                     Copyright (c) 2005 SUDOW-SOKEN                        //
//                      <http://www.mailpark.co.jp/>                         //
Severity: Major
Found in admin/main.php - About 1 day to fix

    File index.php has 526 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
//  ------------------------------------------------------------------------ //
//             --  XoopsHP Module --       Xoops e-Learning System           //
//                     Copyright (c) 2005 SUDOW-SOKEN                        //
//                      <http://www.mailpark.co.jp/>                         //
    Severity: Major
    Found in index.php - About 1 day to fix

      Function listarticles has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
      Open

      function listarticles($secid)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts  = MyTextSanitizer::getInstance();
      Severity: Minor
      Found in index.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sections has 180 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function sections($secid2show = 0)
{
    global $xoopsConfig, $xoopsDB, $xoopsModule, $xoopsModuleConfig;
    xoops_cp_header();
    // JS for checkbox manipulation
      Severity: Major
      Found in admin/main.php - About 7 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function b_XHP_ranking_show($options)
{
    global $xoopsDB, $xoopsUser, $xoopsConfig;
    $myts      = MyTextSanitizer::getInstance();
    $block     = array();
        Severity: Major
        Found in blocks/xhp_block_ranking.php and 1 other location - About 7 hrs to fix
        blocks/xhp_block_completed.php on lines 38..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 227.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function b_XHP_completed_show($options)
{
    global $xoopsDB, $xoopsUser, $xoopsConfig;
    $myts      = MyTextSanitizer::getInstance();
    $block     = array();
        Severity: Major
        Found in blocks/xhp_block_completed.php and 1 other location - About 7 hrs to fix
        blocks/xhp_block_ranking.php on lines 38..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 227.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if ($expire !== '0000-00-00 00:00:00') {
        if ($expire > $currenttime) {
            echo '<b>' . _MD_LT_SET_EXPIRE . '</b>: ';
            echo "<input class='textbox' type='checkbox' name='setexpire' value='1' checked>";
            echo "<input class='textbox' type='text' name='expire' size=19 value='" . $expire . "'> <br>";
        Severity: Major
        Found in admin/main.php and 1 other location - About 6 hrs to fix
        admin/main.php on lines 362..381

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 206.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if ($expire !== '0000-00-00 00:00:00') {
        if ($expire > $currenttime) {
            echo '<b>' . _MD_LT_SET_EXPIRE . '</b>: ';
            echo "<input class='textbox' type='checkbox' name='setexpire' value='1' checked>";
            echo "<input class='textbox' type='text' name='expire' size=19 value='" . $expire . "'> <br>";
        Severity: Major
        Found in admin/main.php and 1 other location - About 6 hrs to fix
        admin/main.php on lines 283..302

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 206.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function sections has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
        Open

        function sections($secid2show = 0)
{
    global $xoopsConfig, $xoopsDB, $xoopsModule, $xoopsModuleConfig;
    xoops_cp_header();
    // JS for checkbox manipulation
        Severity: Minor
        Found in admin/main.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method listarticles has 121 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function listarticles($secid)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts  = MyTextSanitizer::getInstance();
        Severity: Major
        Found in index.php - About 4 hrs to fix

          Function listsections has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

          function listsections()
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsDB, $xoopsUser, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin, $xoopsModuleConfig;
    include XOOPS_ROOT_PATH . '/header.php';
    $myts = MyTextSanitizer::getInstance();
          Severity: Minor
          Found in index.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method portfolio has 91 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function portfolio($sort_key, $secid)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts     = MyTextSanitizer::getInstance();
          Severity: Major
          Found in index.php - About 3 hrs to fix

            Method listsections has 82 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function listsections()
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsDB, $xoopsUser, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin, $xoopsModuleConfig;
    include XOOPS_ROOT_PATH . '/header.php';
    $myts = MyTextSanitizer::getInstance();
            Severity: Major
            Found in index.php - About 3 hrs to fix

              Method secartedit has 80 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function secartedit($artid)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig;
    $myts = MyTextSanitizer::getInstance();
    xoops_cp_header();
              Severity: Major
              Found in admin/main.php - About 3 hrs to fix

                Method viewdetails has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function viewdetails($artid, $sort_key)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts     = MyTextSanitizer::getInstance();
                Severity: Major
                Found in index.php - About 2 hrs to fix

                  Function portfolio has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function portfolio($sort_key, $secid)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts     = MyTextSanitizer::getInstance();
                  Severity: Minor
                  Found in index.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method viewresults has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function viewresults($artid, $sort_key)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTheme, $xoopsLogger, $xoopsModule, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    include dirname(dirname(__DIR__)) . '/header.php';
    $myts = MyTextSanitizer::getInstance();
                  Severity: Major
                  Found in index.php - About 2 hrs to fix

                    Method sectionedit has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function sectionedit($secid)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig;
    xoops_cp_header();
    echo '<h4>' . _AM_SECCONF . '</h4><br>';
                    Severity: Major
                    Found in admin/main.php - About 2 hrs to fix

                      Function viewarticle has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function viewarticle($artid)
{
    global $xoopsConfig, $xoopsModuleConfig, $xoopsUser, $xoopsDB, $xoopsTpl, $isModAdmin, $xoopsUserIsAdmin;
    $myts  = MyTextSanitizer::getInstance();
    $artid = (int)$artid;
                      Severity: Minor
                      Found in index.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          case 'sectiondispchange':
        foreach ($_POST['id'] as $secid) {
            $secid   = (int)$secid;
            $display = (int)(empty($_POST['display'][$secid]) ? 0 : 1);
            include dirname(__DIR__) . '/module_prefix.php';
                      Severity: Major
                      Found in admin/main.php and 1 other location - About 1 hr to fix
                      admin/main.php on lines 539..547

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 116.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language