File mimetypes.php has 620 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
// $Id: comment.php 506 2006-05-26 23:10:37Z skalpa $
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                    Copyright (c) 2000 XOOPS.org                           //

The class XoopsMimetypes_perms has 13 public methods. Consider refactoring XoopsMimetypes_perms to keep number of public methods under 10.

Open

class XoopsMimetypes_perms extends XoopsObject {
    var $db;

    // constructor
    function xoopsmimetypes_perms ($mperm_id=null) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class XoopsMimetypesHandler has an overall complexity of 56 which is very high. The configured complexity threshold is 50.

Open

class XoopsMimetypesHandler extends XoopsObjectHandler {

    function &create($isNew = true) {
        $tplfile = new XoopsTplfile();
        if ($isNew) {

• Exclude checks
  • Disable engine
  • Disable check

The class XoopsMimetypes_permsHandler has an overall complexity of 57 which is very high. The configured complexity threshold is 50.

Open

class XoopsMimetypes_permsHandler extends XoopsObjectHandler {
    var $_errors = array();

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();

• Exclude checks
  • Disable engine
  • Disable check

Method insert has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

Method insert has 48 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

Function get_mimetypes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();
        if ( is_object($OtherCriteria) ) {
            $criteria->add($OtherCriteria, 'AND');

• Read up
  Read up

Function get_mimetypes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();

        if ( is_object($OtherCriteria) ) {

• Read up
  Read up

Method get_mimetypes has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();
        if ( is_object($OtherCriteria) ) {
            $criteria->add($OtherCriteria, 'AND');

Method get_mimetypes has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();

        if ( is_object($OtherCriteria) ) {

Function insert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up

Function insert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up

Function Get_TypeList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    function Get_TypeList() {
        $ret = array();
        $sql = 'SELECT * FROM ' . $this->db->prefix("mimetypes") ;

        $result = $this->db->query($sql);

• Read up
  Read up

Method get_mimetypes has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

Method get_mimetypes has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {

Method XoopsFormSelectType has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

Method XoopsFormSelectMime has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

Function delete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    function delete(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }

• Read up
  Read up

Function allowedMimeTypes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    function allowedMimeTypes( $mid, $groups, $allowedMimeTypes ) {
        $ret = array();
        $sql = 'SELECT p.mperm_groups, t.mime_ext, t.mime_types FROM ' . $this->db->prefix('mimetypes_perms') . ' p LEFT JOIN ' .
        $this->db->prefix("mimetypes") . ' t on p.mperm_mime = t.mime_id WHERE mperm_module=' . $mid;

• Read up
  Read up

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

        return true;

Function GetSelectList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    function &GetSelectList($criteria = null) {
        $ret = array();
        $limit = $start = 0;
        $sql = 'SELECT * FROM '.$this->db->prefix('mimetypes');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

• Read up
  Read up

The method insert() has an NPath complexity of 256. The configured NPath complexity threshold is 200.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method get_mimetypes() has an NPath complexity of 288. The configured NPath complexity threshold is 200.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();
        if ( is_object($OtherCriteria) ) {
            $criteria->add($OtherCriteria, 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method get_mimetypes() has an NPath complexity of 288. The configured NPath complexity threshold is 200.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();

        if ( is_object($OtherCriteria) ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method insert() has an NPath complexity of 256. The configured NPath complexity threshold is 200.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method get_mimetypes() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();

        if ( is_object($OtherCriteria) ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method get_mimetypes() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();
        if ( is_object($OtherCriteria) ) {
            $criteria->add($OtherCriteria, 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Avoid using undefined variables such as '$mime_name' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_name),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_mime' which will lead to PHP notices.

Open

            $mperm_mime,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxwidth' which will lead to PHP notices.

Open

            $mperm_maxwidth,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxheight' which will lead to PHP notices.

Open

            $mperm_maxheight,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_ext' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_ext),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_id' which will lead to PHP notices.

Open

            $mime_id,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_name' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_name),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_status' which will lead to PHP notices.

Open

            $mime_status);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_groups' which will lead to PHP notices.

Open

            $mperm_groups,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_types' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_types),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_module' which will lead to PHP notices.

Open

            $mperm_module,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_id' which will lead to PHP notices.

Open

            $mperm_id,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_groups' which will lead to PHP notices.

Open

            $this->db->quoteString($mperm_groups),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_id' which will lead to PHP notices.

Open

            $mime_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_status' which will lead to PHP notices.

Open

            $mperm_status,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxsize' which will lead to PHP notices.

Open

            $mperm_maxsize,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_ext' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_ext),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_status' which will lead to PHP notices.

Open

            $mime_status,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_status' which will lead to PHP notices.

Open

            $mperm_status,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxsize' which will lead to PHP notices.

Open

            $mperm_maxsize );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_mime' which will lead to PHP notices.

Open

            $mperm_mime,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mime_types' which will lead to PHP notices.

Open

            $this->db->quoteString($mime_types),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_module' which will lead to PHP notices.

Open

            $mperm_module,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxwidth' which will lead to PHP notices.

Open

            $mperm_maxwidth,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_id' which will lead to PHP notices.

Open

            $mperm_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$mperm_maxheight' which will lead to PHP notices.

Open

            $mperm_maxheight,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

The method XoopsFormSelectMime has a boolean flag argument $multiple, which is a certain sign of a Single Responsibility Principle violation.

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '122', column '18').

Open

        $tplfile = new XoopsTplfile();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '142', column '18').

Open

                $ret[] = new xoopsmimetypes( $myrow );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '327', column '14').

Open

        $ret = new XoopsFormSelect($caption, $name, $value, $size, $multiple);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '320', column '19').

Open

        $criteria = new CriteriaCompo();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method deletebyMimeModule has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function deletebyMimeModule(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method deletebyModule has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function deletebyModule(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method create has a boolean flag argument $isNew, which is a certain sign of a Single Responsibility Principle violation.

Open

    function &create($isNew = true) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method get_byExt has a boolean flag argument $asobject, which is a certain sign of a Single Responsibility Principle violation.

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '225', column '27').

Open

            $mimetype_object = new xoopsmimetypes();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method get_mimetypes has a boolean flag argument $asobject, which is a certain sign of a Single Responsibility Principle violation.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function insert(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '189', column '18').

Open

                $ret[] = new xoopsmimetypes( $myrow );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Remove error control operator '@' on line 733.

Open

    function allowedMimeTypes( $mid, $groups, $allowedMimeTypes ) {
        $ret = array();
        $sql = 'SELECT p.mperm_groups, t.mime_ext, t.mime_types FROM ' . $this->db->prefix('mimetypes_perms') . ' p LEFT JOIN ' .
        $this->db->prefix("mimetypes") . ' t on p.mperm_mime = t.mime_id WHERE mperm_module=' . $mid;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function delete(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method get_mimetypes has a boolean flag argument $asobject, which is a certain sign of a Single Responsibility Principle violation.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '494', column '24').

Open

                $criteria->add(new Criteria('p.mperm_module', $v), 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '528', column '18').

Open

                $ret[] = new xoopsmimetypes_perms( $myrow );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function delete(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '319', column '14').

Open

        $ret = new XoopsFormSelect($caption, $name, $value, $size, $multiple);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method deletebyMime has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function deletebyMime(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '595', column '27').

Open

            $mimetype_object = new xoopsmimetypes();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '150', column '19').

Open

        $criteria = new CriteriaCompo();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.

Open

    function insert(&$mimetype_object, $force = false) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '497', column '23').

Open

            $criteria->add(new Criteria('p.mperm_module', $module), 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '158', column '24').

Open

                $criteria->add(new Criteria('mime_status', $v), 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '487', column '19').

Open

        $criteria = new CriteriaCompo();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method get_byMimeModule has a boolean flag argument $asobject, which is a certain sign of a Single Responsibility Principle violation.

Open

    function get_byMimeModule( $mime_id, $mid, $asobject=true) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '161', column '23').

Open

            $criteria->add(new Criteria('mime_status', $status), 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method XoopsFormSelectType has a boolean flag argument $multiple, which is a certain sign of a Single Responsibility Principle violation.

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '546', column '18').

Open

                $ret[] = new xoopsmimetypes_perms( $myrow );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_name'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method get_mimetypes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $ret[] = new xoopsmimetypes( $myrow );
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Database' in method 'xoopsmimetypes'.

Open

        $this->db = Database::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method xoopsmimetypes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $this->setNew();
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_types'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $format = "UPDATE %s SET ";
            $format .="mime_ext=%s, mime_types=%s, mime_name=%s, mime_status=%u";
            $format .=" WHERE mime_id = %u";
            $sql = sprintf($format, $this->db->prefix('mimetypes'),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_module'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid assigning values to variables in if clauses and the like (line '340', column '10').

Open

    function Get_TypeList() {
        $ret = array();
        $sql = 'SELECT * FROM ' . $this->db->prefix("mimetypes") ;

        $result = $this->db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method xoopsmimetypes_perms uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $this->setNew();
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method xoopsmimetypes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->load($mime_id);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_ext'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method get_mimetypes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $ret[] = new xoopsmimetypes_perms( $myrow );
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getHtmlErrors uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $ret .= 'None<br />';
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Database' in method 'xoopsmimetypes_perms'.

Open

        $this->db = Database::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method xoopsmimetypes_perms uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->load($mperm_id);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method get_byExt uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $ret[] = new xoopsmimetypes( $myrow );
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getHtmlErrors uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $ret .= 'None<br />';
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $format = "UPDATE %s SET ";
            $format .="mperm_mime=%u, mperm_module=%u, mperm_groups=%s, mperm_status=%u, mperm_maxwidth=%u, mperm_maxheight=%u, mperm_maxsize=%u";
            $format .=" WHERE mperm_id = %u";
            $sql = sprintf($format, $this->db->prefix('mimetypes_perms'),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method deletebyMimeModule uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_name'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method get_byMimeModule uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $ret[] = new xoopsmimetypes_perms( $myrow );
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method deletebyMime uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method deletebyModule uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $result = $this->db->query($sql);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'MyTextSanitizer' in method 'mime_ext'.

Open

            $myts = &MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Classes should not have a constructor method with the same name as the class

Open

    function xoopsmimetypes_perms ($mperm_id=null) {
        $this->db = Database::getInstance();
        $this->initVar('mperm_id',XOBJ_DTYPE_INT,0,true,10);
        $this->initVar('mperm_mime',XOBJ_DTYPE_INT,0,true,11);
        $this->initVar('mperm_module'  ,XOBJ_DTYPE_INT,0,true,5);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class MyClass {
     // this is bad because it is PHP 4 style
    public function MyClass() {}
    // this is good because it is a PHP 5 constructor
    public function __construct() {}
}

Classes should not have a constructor method with the same name as the class

Open

    function xoopsmimetypes ($mime_id=null) {
        $this->db = Database::getInstance();
        $this->initVar('mime_id',XOBJ_DTYPE_INT,0,true,11);
        $this->initVar('mime_ext',XOBJ_DTYPE_TXTBOX,'',true,10);
        $this->initVar('mime_types',XOBJ_DTYPE_TXTAREA,'',true,0);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class MyClass {
     // this is bad because it is PHP 4 style
    public function MyClass() {}
    // this is good because it is a PHP 5 constructor
    public function __construct() {}
}

Avoid unused parameters such as '$notNullFields'.

Open

    function getCount($criteria = null, $notNullFields='') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$notNullFields'.

Open

    function getCount($criteria = null, $notNullFields='') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function deletebyModule(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function deletebyMimeModule(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_mime = %u AND mperm_module = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_mime'), $mimetype_object->getVar('mperm_module'));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function delete(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_id = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_id'));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    function deletebyMime(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_mime = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_mime'));

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' '.$criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' '.$criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
            }

• Read up
  Read up

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class XoopsMimetypes extends XoopsObject {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class XoopsMimetypesHandler extends XoopsObjectHandler {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class XoopsMimetypes_perms extends XoopsObject {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class XoopsMimetypes_permsHandler extends XoopsObjectHandler {

• Exclude checks
  • Disable engine
  • Disable check

The parameter $mime_ext is not named in camelCase.

Open

    function get_byExt( $mime_ext, $asobject=true ) {
        $ret = array();
        $sql = 'SELECT * FROM ' . $this->db->prefix('mimetypes') . ' WHERE mime_ext = ' . $this->db->quoteString($mime_ext);

        $result = $this->db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $err_str is not named in camelCase.

Open

    function setErrors($err_str) {
        $this->_errors[] = trim($err_str);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The class XoopsMimetypes_perms is not named in CamelCase.

Open

class XoopsMimetypes_perms extends XoopsObject {
    var $db;

    // constructor
    function xoopsmimetypes_perms ($mperm_id=null) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Avoid variables with short names like $db. Configured minimum length is 3.

Open

    var $db;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $mime_id is not named in camelCase.

Open

    function load($mime_id) {
        $sql = 'SELECT * FROM '.$this->db->prefix('mimetypes').' WHERE mime_id='.$mime_id;
        $myrow = $this->db->fetchArray($this->db->query($sql));
        $this->assignVars($myrow);
        if (!$myrow) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mime_ext is not named in camelCase.

Open

    function load_byExt($mime_ext) {
        $sql = 'SELECT * FROM '.$this->db->prefix('mimetypes').' WHERE mime_ext=' . $this->db->quoteString($mime_ext);
        $myrow = $this->db->fetchArray($this->db->query($sql));
        $this->assignVars($myrow);
        if (!$myrow) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mime_id is not named in camelCase.

Open

    function get_byMimeModule( $mime_id, $mid, $asobject=true) {
        $ret = array();
        $sql = 'SELECT * FROM ' . $this->db->prefix('mimetypes_perms') . ' WHERE mperm_mime = ' . $mime_id . ' AND mperm_module = ' . $mid;
        $result = $this->db->query($sql);
        if (!$result) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $module_id is not named in camelCase.

Open

    function load($module_id) {
        $sql = 'SELECT p.*, t.mime_ext, t.mime_name, m.name FROM ' . $this->db->prefix('mimetypes_perms') . ' p LEFT JOIN ' .
        $this->db->prefix("mimetypes") . ' t on p.mperm_mime = t.mime_id LEFT JOIN ' .
        $this->db->prefix("modules") . ' m on p.mperm_module = m.mid' . ' WHERE mperm_id=' . $this->db->quoteString($module_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function deletebyMimeModule(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_mime = %u AND mperm_module = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_mime'), $mimetype_object->getVar('mperm_module'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $OtherCriteria is not named in camelCase.

Open

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();
        if ( is_object($OtherCriteria) ) {
            $criteria->add($OtherCriteria, 'AND');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function deletebyMime(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_mime = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_mime'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mime_id is not named in camelCase.

Open

    function xoopsmimetypes ($mime_id=null) {
        $this->db = Database::getInstance();
        $this->initVar('mime_id',XOBJ_DTYPE_INT,0,true,11);
        $this->initVar('mime_ext',XOBJ_DTYPE_TXTBOX,'',true,10);
        $this->initVar('mime_types',XOBJ_DTYPE_TXTAREA,'',true,0);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function delete(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The property $_errors is not named in camelCase.

Open

class XoopsMimetypes_permsHandler extends XoopsObjectHandler {
    var $_errors = array();

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The class XoopsMimetypes_permsHandler is not named in CamelCase.

Open

class XoopsMimetypes_permsHandler extends XoopsObjectHandler {
    var $_errors = array();

    function get_mimetypes($limit=20, $start=0, $module=-1, $OtherCriteria=null, $asobject=true) {
        $ret = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

The parameter $mimetype_object is not named in camelCase.

Open

    function delete(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }
        $sql = sprintf("DELETE FROM %s WHERE mperm_id = %u", $this->db->prefix("mimetypes_perms"), $mimetype_object->getVar('mperm_id'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function deletebyModule(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes_perms') {
            return false;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $err_str is not named in camelCase.

Open

    function setErrors($err_str) {
        $this->_errors[] = trim($err_str);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Avoid variables with short names like $db. Configured minimum length is 3.

Open

    var $db;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $mperm_id is not named in camelCase.

Open

    function xoopsmimetypes_perms ($mperm_id=null) {
        $this->db = Database::getInstance();
        $this->initVar('mperm_id',XOBJ_DTYPE_INT,0,true,10);
        $this->initVar('mperm_mime',XOBJ_DTYPE_INT,0,true,11);
        $this->initVar('mperm_module'  ,XOBJ_DTYPE_INT,0,true,5);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $OtherCriteria is not named in camelCase.

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {
        $ret = array();
        $criteria = new CriteriaCompo();

        if ( is_object($OtherCriteria) ) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $mimetype_object is not named in camelCase.

Open

    function insert(&$mimetype_object, $force = false) {
        if (strtolower(get_class($mimetype_object)) != 'xoopsmimetypes') {
            return false;
        }
        if (!$mimetype_object->isDirty()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 42 and the first side effect is on line 37.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a file by itself

Open

class XoopsMimetypesHandler extends XoopsObjectHandler {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a file by itself

Open

class XoopsMimetypes_perms extends XoopsObject {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a file by itself

Open

class XoopsMimetypes_permsHandler extends XoopsObjectHandler {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on property "$db"

Open

    var $db;

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "load"

Open

    function load($mime_id) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            if ( is_array($mime_id) ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$mime_id"; expected 1 but found 0

Open

    function xoopsmimetypes ($mime_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class XoopsMimetypes extends XoopsObject {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before opening parenthesis; 1 found

Open

    function xoopsmimetypes ($mime_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$mime_id" and equals sign; expected 1 but found 0

Open

    function xoopsmimetypes ($mime_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "load_byExt"

Open

    function load_byExt($mime_ext) {

• Exclude checks
  • Disable engine
  • Disable check

The var keyword must not be used to declare a property

Open

    var $db;

• Exclude checks
  • Disable engine
  • Disable check

Expected "function abc(...)"; found "function abc (...)"

Open

    function xoopsmimetypes ($mime_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "xoopsmimetypes"

Open

    function xoopsmimetypes ($mime_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::load_byExt" is not in camel caps format

Open

    function load_byExt($mime_ext) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        if ( !empty($mime_id) ) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::mime_ext" is not in camel caps format

Open

    function mime_ext($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "mime_ext"

Open

    function mime_ext($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$start"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$OtherCriteria" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$order"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$format" and equals sign; expected 1 but found 0

Open

    function mime_name($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "get_mimetypes"

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$start" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        if ( isset($status) && (is_array($status)) ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$status"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$asobject"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$format"; expected 1 but found 0

Open

    function mime_types($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$format"; expected 1 but found 0

Open

    function mime_name($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "get_byExt"

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces between opening bracket and argument "$mime_ext"; 1 found

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        if ( is_object($OtherCriteria) ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "create"

Open

    function &create($isNew = true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$status" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$order" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$asobject" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "mime_id"

Open

    function mime_id() {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$format"; expected 1 but found 0

Open

    function mime_ext($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "mime_status"

Open

    function mime_status() {

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class XoopsMimetypesHandler extends XoopsObjectHandler {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$asobject" and equals sign; expected 1 but found 0

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::mime_id" is not in camel caps format

Open

    function mime_id() {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "mime_types"

Open

    function mime_types($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "mime_name"

Open

    function mime_name($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$limit"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::mime_status" is not in camel caps format

Open

    function mime_status() {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        while ( $myrow = $this->db->fetchArray($result) ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            if ( !$asobject ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$asobject"; expected 1 but found 0

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$OtherCriteria"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        } elseif ( isset($status) && ($status != -1) ) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::mime_types" is not in camel caps format

Open

    function mime_types($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes::mime_name" is not in camel caps format

Open

    function mime_name($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::get_mimetypes" is not in camel caps format

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces between argument "$asobject" and closing bracket; 1 found

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$sort" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$sort"; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$format" and equals sign; expected 1 but found 0

Open

    function mime_types($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$format" and equals sign; expected 1 but found 0

Open

    function mime_ext($format='S') {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::get_byExt" is not in camel caps format

Open

    function get_byExt( $mime_ext, $asobject=true ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$limit" and equals sign; expected 1 but found 0

Open

    function get_mimetypes($limit=20, $start=0, $status=-1, $OtherCriteria=null, $sort='mime_ext', $order='ASC', $asobject=true) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$size"; expected 1 but found 0

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "Get_TypeList"

Open

    function Get_TypeList() {

• Exclude checks
  • Disable engine
  • Disable check

Space found before comma in function call

Open

        $this->initVar('mperm_status'  ,XOBJ_DTYPE_INT,0,true,1);

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces between opening bracket and argument "$caption"; 1 found

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "setErrors"

Open

    function setErrors($err_str) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$mperm_id" and equals sign; expected 1 but found 0

Open

    function xoopsmimetypes_perms ($mperm_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Space found before comma in function call

Open

        $this->initVar('mperm_module'  ,XOBJ_DTYPE_INT,0,true,5);

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$value" and equals sign; expected 1 but found 0

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::Get_TypeList" is not in camel caps format

Open

    function Get_TypeList() {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before opening parenthesis; 1 found

Open

    function xoopsmimetypes_perms ($mperm_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "getCount"

Open

    function getCount($criteria = null, $notNullFields='') {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "insert"

Open

    function insert(&$mimetype_object, $force = false) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$multiple" and equals sign; expected 1 but found 0

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            if ( !$asobject ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$notNullFields"; expected 1 but found 0

Open

    function getCount($criteria = null, $notNullFields='') {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::GetSelectList" is not in camel caps format

Open

    function &GetSelectList($criteria = null) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces between opening bracket and argument "$caption"; 1 found

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$value"; expected 1 but found 0

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on property "$db"

Open

    var $db;

• Exclude checks
  • Disable engine
  • Disable check

Space found before comma in function call

Open

        $this->initVar('mperm_groups'  ,XOBJ_DTYPE_TXTAREA,'',false,0);

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$notNullFields" and equals sign; expected 1 but found 0

Open

    function getCount($criteria = null, $notNullFields='') {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

                if ( $type = substr( $mime_type, 0, strpos($mime_type, '/') ) ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$mperm_id"; expected 1 but found 0

Open

    function xoopsmimetypes_perms ($mperm_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        while ( $myrow = $this->db->fetchArray($result) ) {

• Exclude checks
  • Disable engine
  • Disable check

Space found before comma in function call

Open

        $this->initVar('mperm_maxwidth'  ,XOBJ_DTYPE_INT,0,true,4);

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::XoopsFormSelectMime" is not in camel caps format

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "XoopsFormSelectMime"

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypesHandler::XoopsFormSelectType" is not in camel caps format

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces between argument "$multiple" and closing bracket; 1 found

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

                    if ( !in_array ($type, $ret) ) {

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class XoopsMimetypes_perms extends XoopsObject {

• Exclude checks
  • Disable engine
  • Disable check

Method name "XoopsMimetypes_perms::xoopsmimetypes_perms" is not in camel caps format

Open

    function xoopsmimetypes_perms ($mperm_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$multiple" and equals sign; expected 1 but found 0

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

The var keyword must not be used to declare a property

Open

    var $db;

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between default value and equals sign for argument "$size"; expected 1 but found 0

Open

    function XoopsFormSelectMime( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Incorrect spacing between argument "$size" and equals sign; expected 1 but found 0

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "getHtmlErrors"

Open

    function getHtmlErrors() {

• Exclude checks
  • Disable engine
  • Disable check

Empty lines are not allowed in multi-line function calls

Open

• Exclude checks
  • Disable engine
  • Disable check

Visibility must be declared on method "XoopsFormSelectType"

Open

    function XoopsFormSelectType( $caption, $name, $value=null, $size=1, $multiple=false ) {

• Exclude checks
  • Disable engine
  • Disable check

Space found before closing bracket of FOREACH loop

Open

            foreach ( $mime_types as $mime_type ) {

• Exclude checks
  • Disable engine
  • Disable check

Expected "function abc(...)"; found "function abc (...)"

Open

    function xoopsmimetypes_perms ($mperm_id=null) {

• Exclude checks
  • Disable engine
  • Disable check

Space found before comma in function call

Open

            $sql = sprintf($format ,

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

        while ( $myrow = $this->db->fetchArray($result) ) {