Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
declare(strict_types=1);
/**
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1663.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 20 and the first side effect is on line 107. Open
<?php
- Exclude checks
Line exceeds 120 characters; contains 175 characters Open
define('_AM_XI_MAKE_UPGRADE', "Une nouvelle version de <font color='#CC0000'>" . $xoopsModule->name() . '</font> est disponible<br>en t�l�chargement � cette adresse :');
- Exclude checks
Line exceeds 120 characters; contains 202 characters Open
define('_AM_XI_PROTECTOR_CHECK_ERR', " Vous devez �diter le fichier mainfile.php comme indiqu� dans le fichier <a target='_blank' href='" . XOOPS_URL . "/modules/protector/docs/README'>README</a>");
- Exclude checks
Line exceeds 120 characters; contains 245 characters Open
define('_AM_XI_MIME_TYPE', "Mimetypes<br><br><span style='font-weight: normal;'>Entrer les mimetype associ� avec cette extension de fichier.<br>Tous les mimetype doivent entre s�par�s par un <font color='#CC0000'><b>|</b></font>.</span>");
- Exclude checks