Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

/**
Severity: Major
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php and 4 other locations - About 2 hrs to fix
phpsecinfo/PhpSecInfo/Test/CGI/force_redirect.php on lines 1..67
phpsecinfo/PhpSecInfo/Test/Core/display_errors.php on lines 1..60
phpsecinfo/PhpSecInfo/Test/Core/open_basedir.php on lines 1..66
phpsecinfo/PhpSecInfo/Test/Session/use_trans_sid.php on lines 1..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class PhpSecInfo_Test_Core_Allow_Url_Fopen extends PhpSecInfo_Test_Core
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

The class PhpSecInfo_Test_Core_Allow_Url_Fopen is not named in CamelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Fopen extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $test_name is not named in camelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Fopen extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $recommended_value is not named in camelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Fopen extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 20 and the first side effect is on line 15.
Open

<?php
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Method name "_retrieveCurrentValue" should not be prefixed with an underscore to indicate visibility
Open

    public function _retrieveCurrentValue()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Method name "_execTest" should not be prefixed with an underscore to indicate visibility
Open

    public function _execTest()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Method name "_setMessages" should not be prefixed with an underscore to indicate visibility
Open

    public function _setMessages()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Line exceeds 120 characters; contains 133 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'allow_url_fopen is disabled, which is the recommended setting');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Line exceeds 120 characters; contains 261 characters
Open

                                   'allow_url_fopen is enabled.  This could be a serious security risk.  You should disable allow_url_fopen and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Class name "PhpSecInfo_Test_Core_Allow_Url_Fopen" is not in camel caps format
Open

class PhpSecInfo_Test_Core_Allow_Url_Fopen extends PhpSecInfo_Test_Core
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'allow_url_fopen is enabled.  This could be a serious security risk.  You should disable allow_url_fopen and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'allow_url_fopen is enabled.  This could be a serious security risk.  You should disable allow_url_fopen and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpcodesniffer

The method _execTest is not named in camelCase.
Open

    public function _execTest()
    {
        if ($this->current_value == $this->recommended_value) {
            return PHPSECINFO_TEST_RESULT_OK;
        }
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setMessages is not named in camelCase.
Open

    public function _setMessages()
    {
        parent::_setMessages();

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'allow_url_fopen is disabled, which is the recommended setting');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _retrieveCurrentValue is not named in camelCase.
Open

    public function _retrieveCurrentValue()
    {
        $this->current_value = $this->getBooleanIniValue('allow_url_fopen');
    }
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_fopen.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status