Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php

Summary

Maintainability
A
0 mins
Test Coverage

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class PhpSecInfo_Test_Core_Allow_Url_Include extends PhpSecInfo_Test_Core
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

The property $recommended_value is not named in camelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Include extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $test_name is not named in camelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Include extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class PhpSecInfo_Test_Core_Allow_Url_Include is not named in CamelCase.
Open

class PhpSecInfo_Test_Core_Allow_Url_Include extends PhpSecInfo_Test_Core
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 20 and the first side effect is on line 15.
Open

<?php
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Method name "_retrieveCurrentValue" should not be prefixed with an underscore to indicate visibility
Open

    public function _retrieveCurrentValue()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Method name "_setMessages" should not be prefixed with an underscore to indicate visibility
Open

    public function _setMessages()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Method name "_execTest" should not be prefixed with an underscore to indicate visibility
Open

    public function _execTest()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Line exceeds 120 characters; contains 265 characters
Open

                                   'allow_url_include is enabled.  This could be a serious security risk.  You should disable allow_url_include and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Line exceeds 120 characters; contains 163 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTRUN, 'en', 'You are running a version of PHP older than 5.2, and allow_url_include is not available');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Line exceeds 120 characters; contains 135 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'allow_url_include is disabled, which is the recommended setting');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'allow_url_include is enabled.  This could be a serious security risk.  You should disable allow_url_include and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'allow_url_include is enabled.  This could be a serious security risk.  You should disable allow_url_include and consider using the <a href="http://php.net/manual/en/ref.curl.php" target="_blank">PHP cURL functions</a> instead.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

Class name "PhpSecInfo_Test_Core_Allow_Url_Include" is not in camel caps format
Open

class PhpSecInfo_Test_Core_Allow_Url_Include extends PhpSecInfo_Test_Core
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpcodesniffer

The method _retrieveCurrentValue is not named in camelCase.
Open

    public function _retrieveCurrentValue()
    {
        $this->current_value = $this->getBooleanIniValue('allow_url_include');
    }
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _execTest is not named in camelCase.
Open

    public function _execTest()
    {
        if ($this->current_value == $this->recommended_value) {
            return PHPSECINFO_TEST_RESULT_OK;
        }
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setMessages is not named in camelCase.
Open

    public function _setMessages()
    {
        parent::_setMessages();

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTRUN, 'en', 'You are running a version of PHP older than 5.2, and allow_url_include is not available');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Core/allow_url_include.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status