XoopsModules25x/xoopsinfo

View on GitHub
phpsecinfo/PhpSecInfo/Test/Curl/file_support.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused local variables such as '$curlinfo'.
Open

        $curlinfo = curl_version();

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class PhpSecInfo_Test_Curl_File_Support extends PhpSecInfo_Test_Curl

The property $recommended_value is not named in camelCase.
Open

class PhpSecInfo_Test_Curl_File_Support extends PhpSecInfo_Test_Curl
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $test_name is not named in camelCase.
Open

class PhpSecInfo_Test_Curl_File_Support extends PhpSecInfo_Test_Curl
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class PhpSecInfo_Test_Curl_File_Support is not named in CamelCase.
Open

class PhpSecInfo_Test_Curl_File_Support extends PhpSecInfo_Test_Curl
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 25 and the first side effect is on line 15.
Open

<?php

Method name "_execTest" should not be prefixed with an underscore to indicate visibility
Open

    public function _execTest()

Method name "_retrieveCurrentValue" should not be prefixed with an underscore to indicate visibility
Open

    public function _retrieveCurrentValue()

Method name "_setMessages" should not be prefixed with an underscore to indicate visibility
Open

    public function _setMessages()

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en',

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'fr',

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'fr',

Line exceeds 120 characters; contains 125 characters
Open

            || (version_compare($this->current_value, '4.4.4', '>=')) && (version_compare($this->current_value, '5', '<'))) {

Line exceeds 120 characters; contains 246 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en', 'A security hole present in your version of PHP allows the cURL functions to bypass safe_mode and open_basedir restrictions. You should upgrade to the latest version of PHP.');

Line exceeds 120 characters; contains 232 characters
Open

                                   'You are running PHP 4.4.4 or higher, or PHP 5.1.6 or higher.  These versions fix the security hole present in the cURL functions that allow it to bypass safe_mode and open_basedir restrictions.');

Line exceeds 120 characters; contains 266 characters
Open

                                   'Vous utilisez PHP 4.4.4 ou supérieur, ou PHP 5.1.6 ou supérieur. Ces versions corrigent les failles de sécurité présentes dans les fonctions cURL qui lui permettent de contourner les restrictions safe_mode et open_basedir.');

Line exceeds 120 characters; contains 235 characters
Open

                                   'Une faille de sécurité présente dans votre version de PHP permet aux fonctions cURL de contourner les restrictions safe_mode et open_basedir. Vous devriez passer à la dernière version de PHP.');

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'Une faille de sécurité présente dans votre version de PHP permet aux fonctions cURL de contourner les restrictions safe_mode et open_basedir. Vous devriez passer à la dernière version de PHP.');

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'You are running PHP 4.4.4 or higher, or PHP 5.1.6 or higher.  These versions fix the security hole present in the cURL functions that allow it to bypass safe_mode and open_basedir restrictions.');

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'fr',

Class name "PhpSecInfo_Test_Curl_File_Support" is not in camel caps format
Open

class PhpSecInfo_Test_Curl_File_Support extends PhpSecInfo_Test_Curl

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'Vous utilisez PHP 4.4.4 ou supérieur, ou PHP 5.1.6 ou supérieur. Ces versions corrigent les failles de sécurité présentes dans les fonctions cURL qui lui permettent de contourner les restrictions safe_mode et open_basedir.');

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'Vous utilisez PHP 4.4.4 ou supérieur, ou PHP 5.1.6 ou supérieur. Ces versions corrigent les failles de sécurité présentes dans les fonctions cURL qui lui permettent de contourner les restrictions safe_mode et open_basedir.');

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'Une faille de sécurité présente dans votre version de PHP permet aux fonctions cURL de contourner les restrictions safe_mode et open_basedir. Vous devriez passer à la dernière version de PHP.');

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'You are running PHP 4.4.4 or higher, or PHP 5.1.6 or higher.  These versions fix the security hole present in the cURL functions that allow it to bypass safe_mode and open_basedir restrictions.');

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'fr',

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en',

The method _execTest is not named in camelCase.
Open

    public function _execTest()
    {
        $curlinfo = curl_version();

        if (version_compare($this->current_value, '5.1.6', '>=')

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setMessages is not named in camelCase.
Open

    public function _setMessages()
    {
        parent::_setMessages();

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en',

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _retrieveCurrentValue is not named in camelCase.
Open

    public function _retrieveCurrentValue()
    {
        $this->current_value = PHP_VERSION;
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status