Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _retrieveCurrentValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->current_value = 'Disabled';
        }
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class PhpSecInfo_Test_Functions_Apache_Setenv extends PhpSecInfo_Test_Functions
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

The property $recommended_value is not named in camelCase.
Open

class PhpSecInfo_Test_Functions_Apache_Setenv extends PhpSecInfo_Test_Functions
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $test_name is not named in camelCase.
Open

class PhpSecInfo_Test_Functions_Apache_Setenv extends PhpSecInfo_Test_Functions
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class PhpSecInfo_Test_Functions_Apache_Setenv is not named in CamelCase.
Open

class PhpSecInfo_Test_Functions_Apache_Setenv extends PhpSecInfo_Test_Functions
{
    /**
     * This should be a <b>unique</b>, human-readable identifier for this test
     *
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 23 and the first side effect is on line 15.
Open

<?php
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Method name "_setMessages" should not be prefixed with an underscore to indicate visibility
Open

    public function _setMessages()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Method name "_execTest" should not be prefixed with an underscore to indicate visibility
Open

    public function _execTest()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Method name "_retrieveCurrentValue" should not be prefixed with an underscore to indicate visibility
Open

    public function _retrieveCurrentValue()
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTICE, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Line exceeds 120 characters; contains 143 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'You have this function listed in your php.ini under disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Line exceeds 120 characters; contains 214 characters
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Line exceeds 120 characters; contains 253 characters
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'fr', 'Vous avez listé cette fonction dans votre php.ini sous disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTICE, 'en',
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Class name "PhpSecInfo_Test_Functions_Apache_Setenv" is not in camel caps format
Open

class PhpSecInfo_Test_Functions_Apache_Setenv extends PhpSecInfo_Test_Functions
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 35
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                                   'This function is not in your php.ini disabled_functions and is enabled.  This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpcodesniffer

The method _setMessages is not named in camelCase.
Open

    public function _setMessages()
    {
        parent::_setMessages();

        $this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'You have this function listed in your php.ini under disabled_functions.');
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _retrieveCurrentValue is not named in camelCase.
Open

    public function _retrieveCurrentValue()
    {
        if (function_exists($this->test_name)) {
            $this->current_value = 'Enabled';
        } else {
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _execTest is not named in camelCase.
Open

    public function _execTest()
    {
        // Check if function exists
        if (function_exists($this->test_name)) {
            return PHPSECINFO_TEST_RESULT_WARN;
Severity: Minor
Found in phpsecinfo/PhpSecInfo/Test/Functions/apache_setenv.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status