The method _retrieveCurrentValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->current_value = 'Disabled';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Similar blocks of code found in 46 locations. Consider refactoring. Open
<?php
declare(strict_types=1);
/**
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 175.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long class names like PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode. Keep class name length under 40. Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
{
/**
* This should be a <b>unique</b>, human-readable identifier for this test
*
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}
Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
- Exclude checks
The class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode is not named in CamelCase. Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
{
/**
* This should be a <b>unique</b>, human-readable identifier for this test
*
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The property $test_name is not named in camelCase. Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
{
/**
* This should be a <b>unique</b>, human-readable identifier for this test
*
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $recommended_value is not named in camelCase. Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
{
/**
* This should be a <b>unique</b>, human-readable identifier for this test
*
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 23 and the first side effect is on line 15. Open
<?php
- Exclude checks
Method name "_retrieveCurrentValue" should not be prefixed with an underscore to indicate visibility Open
public function _retrieveCurrentValue()
- Exclude checks
Method name "_setMessages" should not be prefixed with an underscore to indicate visibility Open
public function _setMessages()
- Exclude checks
Method name "_execTest" should not be prefixed with an underscore to indicate visibility Open
public function _execTest()
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTICE, 'en',
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
- Exclude checks
Line exceeds 120 characters; contains 253 characters Open
'This function is not in your php.ini disabled_functions and is enabled. This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
- Exclude checks
Line exceeds 120 characters; contains 214 characters Open
'This function is not in your php.ini disabled_functions and is enabled. Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
- Exclude checks
Line exceeds 120 characters; contains 143 characters Open
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'You have this function listed in your php.ini under disabled_functions.');
- Exclude checks
Class name "PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode" is not in camel caps format Open
class PhpSecInfo_Test_Functions_PhpAds_XmlrpcEncode extends PhpSecInfo_Test_Functions
- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
'This function is not in your php.ini disabled_functions and is enabled. Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_WARN, 'en',
- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_NOTICE, 'en',
- Exclude checks
Multi-line function call not indented correctly; expected 8 spaces but found 35 Open
'This function is not in your php.ini disabled_functions and is enabled. This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
'This function is not in your php.ini disabled_functions and is enabled. This function can cause serious security implications, unless you absolutely need this function you should add it to your disabled_functions.');
- Exclude checks
Multi-line function call not indented correctly; expected 8 spaces but found 35 Open
'This function is not in your php.ini disabled_functions and is enabled. Use caution with this function and if you do not need it explicitly add it to your disabled_functions.');
- Exclude checks
The method _retrieveCurrentValue is not named in camelCase. Open
public function _retrieveCurrentValue()
{
if (function_exists($this->test_name)) {
$this->current_value = 'Enabled';
} else {
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _execTest is not named in camelCase. Open
public function _execTest()
{
// Check if function exists
if (function_exists($this->test_name)) {
return PHPSECINFO_TEST_RESULT_WARN;
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _setMessages is not named in camelCase. Open
public function _setMessages()
{
parent::_setMessages();
$this->setMessageForResult(PHPSECINFO_TEST_RESULT_OK, 'en', 'You have this function listed in your php.ini under disabled_functions.');
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}