Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsysinfo/includes/mb/class.freeipmi.inc.php

Summary

Maintainability
F
3 days
Test Coverage

The class FreeIPMI has an overall complexity of 50 which is very high. The configured complexity threshold is 50.
Open

class FreeIPMI extends Sensors
{
    /**
     * content to parse
     *
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

Function _current has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function _current()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "A") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _voltage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function _voltage()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Voltage" && $buffer[11] != "N/A" && $buffer[4] == "V") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _fans has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function _fans()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Fan" && $buffer[11] != "N/A" && $buffer[4] == "RPM") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _temperature has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function _temperature()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Temperature" && $buffer[11] != "N/A" && $buffer[4] == "C") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _power has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function _power()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "W") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using undefined variables such as '$lines' which will lead to PHP notices.
Open

            $this->_lines = preg_split("/\n/", $lines, -1, PREG_SPLIT_NO_EMPTY);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$lines' which will lead to PHP notices.
Open

            CommonFunctions::executeProgram('ipmi-sensors', '--output-sensor-thresholds', $lines);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$lines' which will lead to PHP notices.
Open

                $this->_lines = preg_split("/\n/", $lines, -1, PREG_SPLIT_NO_EMPTY);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$lines' which will lead to PHP notices.
Open

            if (CommonFunctions::rfts(PSI_APP_ROOT.'/data/freeipmi.txt', $lines)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Missing class import via use statement (line '121', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '97', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '141', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '56', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '76', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '163', column '28').
Open

                $dev = new SensorDevice();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'CommonFunctions' in method '__construct'.
Open

            if (CommonFunctions::rfts(PSI_APP_ROOT.'/data/freeipmi.txt', $lines)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'CommonFunctions' in method '__construct'.
Open

            CommonFunctions::executeProgram('ipmi-sensors', '--output-sensor-thresholds', $lines);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function _voltage()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Voltage" && $buffer[11] != "N/A" && $buffer[4] == "V") {
Severity: Major
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php and 1 other location - About 5 hrs to fix
phpsysinfo/includes/mb/class.freeipmi.inc.php on lines 136..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function _current()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "A") {
Severity: Major
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php and 1 other location - About 5 hrs to fix
phpsysinfo/includes/mb/class.freeipmi.inc.php on lines 71..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function _temperature()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Temperature" && $buffer[11] != "N/A" && $buffer[4] == "C") {
Severity: Major
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php and 1 other location - About 4 hrs to fix
phpsysinfo/includes/mb/class.freeipmi.inc.php on lines 116..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function _power()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "W") {
Severity: Major
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php and 1 other location - About 4 hrs to fix
phpsysinfo/includes/mb/class.freeipmi.inc.php on lines 51..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct()
    {
        parent::__construct();
        switch (defined('PSI_SENSOR_FREEIPMI_ACCESS')?strtolower(PSI_SENSOR_FREEIPMI_ACCESS):'command') {
        case 'command':
Severity: Major
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php and 1 other location - About 4 hrs to fix
phpsysinfo/includes/mb/class.ipmiutil.inc.php on lines 27..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class FreeIPMI extends Sensors
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

The property $_lines is not named in camelCase.
Open

class FreeIPMI extends Sensors
{
    /**
     * content to parse
     *
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Terminating statement must be indented to the same level as the CASE body
Open

            break;
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_voltage" should not be prefixed with an underscore to indicate visibility
Open

    private function _voltage()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Terminating statement must be indented to the same level as the CASE body
Open

            break;
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Property name "$_lines" should not be prefixed with an underscore to indicate visibility
Open

    private $_lines = array();
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_temperature" should not be prefixed with an underscore to indicate visibility
Open

    private function _temperature()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Terminating statement must be indented to the same level as the CASE body
Open

            break;
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_other" should not be prefixed with an underscore to indicate visibility
Open

    private function _other()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_current" should not be prefixed with an underscore to indicate visibility
Open

    private function _current()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_power" should not be prefixed with an underscore to indicate visibility
Open

    private function _power()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Method name "_fans" should not be prefixed with an underscore to indicate visibility
Open

    private function _fans()
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[9] != "N/A") $dev->setMax($buffer[9]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[11] != "'OK'") $dev->setEvent(trim($buffer[11], "'"));
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[11] != "'OK'") $dev->setEvent(trim($buffer[11], "'"));
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[9] != "N/A") $dev->setMax($buffer[9]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[9] != "N/A") $dev->setMax($buffer[9]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[6] != "N/A") $dev->setMin($buffer[6]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[11] != "'OK'") $dev->setEvent(trim($buffer[11], "'"));
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[9] != "N/A") $dev->setMax($buffer[9]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[11] != "'OK'") $dev->setEvent(trim($buffer[11], "'"));
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[6] != "N/A") $dev->setMin($buffer[6]);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Inline control structures are not allowed
Open

                if ($buffer[11] != "'OK'") $dev->setEvent(trim($buffer[11], "'"));
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected at least 20 spaces, found 16
Open

                $this->_lines = preg_split("/\n/", $lines, -1, PREG_SPLIT_NO_EMPTY);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 12 spaces, found 8
Open

        case 'command':
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 16 spaces, found 12
Open

            if (CommonFunctions::rfts(PSI_APP_ROOT.'/data/freeipmi.txt', $lines)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 16 spaces, found 12
Open

            }
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $this->error->addConfigError('__construct()', '[sensor_freeipmi] ACCESS');
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            CommonFunctions::executeProgram('ipmi-sensors', '--output-sensor-thresholds', $lines);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $this->_lines = preg_split("/\n/", $lines, -1, PREG_SPLIT_NO_EMPTY);
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 12 spaces, found 8
Open

        default:
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 12 spaces, found 8
Open

        case 'data':
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Line indented incorrectly; expected 12 spaces, found 13
Open

             if ($buffer[4] == "N/A"
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

Closing brace indented incorrectly; expected 13 spaces, found 12
Open

            }
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpcodesniffer

The method _fans is not named in camelCase.
Open

    private function _fans()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Fan" && $buffer[11] != "N/A" && $buffer[4] == "RPM") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _voltage is not named in camelCase.
Open

    private function _voltage()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Voltage" && $buffer[11] != "N/A" && $buffer[4] == "V") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _current is not named in camelCase.
Open

    private function _current()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "A") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _power is not named in camelCase.
Open

    private function _power()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Current" && $buffer[11] != "N/A" && $buffer[4] == "W") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _temperature is not named in camelCase.
Open

    private function _temperature()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
            if ($buffer[2] == "Temperature" && $buffer[11] != "N/A" && $buffer[4] == "C") {
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _other is not named in camelCase.
Open

    private function _other()
    {
        foreach ($this->_lines as $line) {
            $buffer = preg_split("/\s*\|\s*/", $line);
             if ($buffer[4] == "N/A"
Severity: Minor
Found in phpsysinfo/includes/mb/class.freeipmi.inc.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status