XoopsModules25x/xoopsinfo

View on GitHub
phpsysinfo/includes/mb/class.lmsensors.inc.php

Summary

Maintainability
F
6 days
Test Coverage

Function _temperature has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
Open

    private function _temperature()
    {
        $applesmc = false;
        $sname = '';
        foreach ($this->_lines as $line) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _current has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    private function _current()
    {
        $sname = '';
        foreach ($this->_lines as $line) {
            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _voltage has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    private function _voltage()
    {
        $sname = '';
        foreach ($this->_lines as $line) {
            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _fans has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    private function _fans()
    {
        $sname = '';
        foreach ($this->_lines as $line) {
            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _power has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    private function _power()
    {
        $sname = '';
        foreach ($this->_lines as $line) {
            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class.lmsensors.inc.php has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * lmsensor sensor class, getting information from lmsensor
 *
 * PHP version 5
Severity: Minor
Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 4 hrs to fix

    Method _temperature has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function _temperature()
        {
            $applesmc = false;
            $sname = '';
            foreach ($this->_lines as $line) {
    Severity: Major
    Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 3 hrs to fix

      The class LMSensors has an overall complexity of 110 which is very high. The configured complexity threshold is 50.
      Open

      class LMSensors extends Sensors
      {
          /**
           * content to parse
           *

      Function _other has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _other()
          {
              $sname = '';
              foreach ($this->_lines as $line) {
                  if ((trim($line) !== "") && (strpos($line, ':') === false)) {
      Severity: Minor
      Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _voltage has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function _voltage()
          {
              $sname = '';
              foreach ($this->_lines as $line) {
                  if ((trim($line) !== "") && (strpos($line, ':') === false)) {
      Severity: Minor
      Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 hr to fix

        Method _current has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function _current()
            {
                $sname = '';
                foreach ($this->_lines as $line) {
                    if ((trim($line) !== "") && (strpos($line, ':') === false)) {
        Severity: Minor
        Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 hr to fix

          Method _fans has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function _fans()
              {
                  $sname = '';
                  foreach ($this->_lines as $line) {
                      if ((trim($line) !== "") && (strpos($line, ':') === false)) {
          Severity: Minor
          Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 hr to fix

            Method _power has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function _power()
                {
                    $sname = '';
                    foreach ($this->_lines as $line) {
                        if ((trim($line) !== "") && (strpos($line, ':') === false)) {
            Severity: Minor
            Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 hr to fix

              Method _other has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function _other()
                  {
                      $sname = '';
                      foreach ($this->_lines as $line) {
                          if ((trim($line) !== "") && (strpos($line, ':') === false)) {
              Severity: Minor
              Found in phpsysinfo/includes/mb/class.lmsensors.inc.php - About 1 hr to fix

                The method _current() has an NPath complexity of 401. The configured NPath complexity threshold is 200.
                Open

                    private function _current()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _fans() has an NPath complexity of 261. The configured NPath complexity threshold is 200.
                Open

                    private function _fans()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _voltage() has an NPath complexity of 401. The configured NPath complexity threshold is 200.
                Open

                    private function _voltage()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _power() has an NPath complexity of 229. The configured NPath complexity threshold is 200.
                Open

                    private function _power()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _temperature() has an NPath complexity of 60321. The configured NPath complexity threshold is 200.
                Open

                    private function _temperature()
                    {
                        $applesmc = false;
                        $sname = '';
                        foreach ($this->_lines as $line) {

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _fans() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _fans()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _other() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _other()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _power() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _power()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _current() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _current()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _temperature() has a Cyclomatic Complexity of 39. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _temperature()
                    {
                        $applesmc = false;
                        $sname = '';
                        foreach ($this->_lines as $line) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _voltage() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _voltage()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Missing class import via use statement (line '294', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '349', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '386', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '134', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '237', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '187', column '28').
                Open

                                $dev = new SensorDevice();

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
                    return new \stdClass();
                }

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                The method _voltage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                preg_match("/^(.+):(.+) V$/", $line, $data);
                            }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _temperature uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $data[$key] = trim($value);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _voltage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $data[$key] = trim($value);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid using static access to class 'CommonFunctions' in method '__construct'.
                Open

                            CommonFunctions::executeProgram("sensors", "", $lines);

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
                {
                    public function bar()
                    {
                        Bar::baz();
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                The method _temperature uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                preg_match("/^(.+):(.+).C$/", $line, $data);
                            }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _voltage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _power uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _power uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                preg_match("/^(.+):(.+) W$/", $line, $data);
                            }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _fans uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                preg_match("/^(.+):(.+) RPM$/", $line, $data);
                            }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _current uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                preg_match("/^(.+):(.+) A$/", $line, $data);
                            }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _other uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _fans uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _power uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $data[$key] = trim($value);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _current uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _other uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $dev->setValue($data[2]);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _temperature uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $sname = '';
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _other uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    $dev->setValue($data[2]);
                                }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid using static access to class 'CommonFunctions' in method '__construct'.
                Open

                            CommonFunctions::rfts(PSI_APP_ROOT.'/data/lmsensors.txt', $lines);

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
                {
                    public function bar()
                    {
                        Bar::baz();
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                The method _fans uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $data[$key] = trim($value);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _current uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        $data[$key] = trim($value);
                                    }

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
                                $sname = trim($line);
                                if (preg_match('/^([^-]+)-/', $sname, $snamebuf)) {
                                    $sname = ' ('.$snamebuf[1].')';
                                } else {
                Severity: Major
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 4 other locations - About 55 mins to fix
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 159..166
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 263..270
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 323..330
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 375..382

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
                                $sname = trim($line);
                                if (preg_match('/^([^-]+)-/', $sname, $snamebuf)) {
                                    $sname = ' ('.$snamebuf[1].')';
                                } else {
                Severity: Major
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 4 other locations - About 55 mins to fix
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 159..166
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 210..217
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 263..270
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 323..330

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
                                $sname = trim($line);
                                if (preg_match('/^([^-]+)-/', $sname, $snamebuf)) {
                                    $sname = ' ('.$snamebuf[1].')';
                                } else {
                Severity: Major
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 4 other locations - About 55 mins to fix
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 159..166
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 210..217
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 263..270
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 375..382

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
                                $sname = trim($line);
                                if (preg_match('/^([^-]+)-/', $sname, $snamebuf)) {
                                    $sname = ' ('.$snamebuf[1].')';
                                } else {
                Severity: Major
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 4 other locations - About 55 mins to fix
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 210..217
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 263..270
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 323..330
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 375..382

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {
                                $sname = trim($line);
                                if (preg_match('/^([^-]+)-/', $sname, $snamebuf)) {
                                    $sname = ' ('.$snamebuf[1].')';
                                } else {
                Severity: Major
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 4 other locations - About 55 mins to fix
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 159..166
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 210..217
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 323..330
                phpsysinfo/includes/mb/class.lmsensors.inc.php on lines 375..382

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        switch (defined('PSI_SENSOR_LMSENSORS_ACCESS')?strtolower(PSI_SENSOR_LMSENSORS_ACCESS):'command') {
                        case 'command':
                            CommonFunctions::executeProgram("sensors", "", $lines);
                            break;
                        case 'data':
                Severity: Minor
                Found in phpsysinfo/includes/mb/class.lmsensors.inc.php and 1 other location - About 30 mins to fix
                phpsysinfo/includes/mb/class.ipmitool.inc.php on lines 31..41

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Each class must be in a namespace of at least one level (a top-level vendor name)
                Open

                class LMSensors extends Sensors

                The property $_lines is not named in camelCase.
                Open

                class LMSensors extends Sensors
                {
                    /**
                     * content to parse
                     *

                CamelCasePropertyName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name attributes.

                Example

                class ClassName {
                    protected $property_name;
                }

                Source

                Terminating statement must be indented to the same level as the CASE body
                Open

                            break;

                Expected 1 space after "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Property name "$_lines" should not be prefixed with an underscore to indicate visibility
                Open

                    private $_lines = array();

                Expected 1 space before "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Expected 1 space after "=>"; 0 found
                Open

                                 foreach ($data as $key=>$value) {

                Method name "_other" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _other()

                Method name "_temperature" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _temperature()

                Expected 1 space before "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Expected 1 space before "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Method name "_fans" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _fans()

                Terminating statement must be indented to the same level as the CASE body
                Open

                            break;

                Expected 1 space after "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Method name "_current" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _current()

                Method name "_voltage" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _voltage()

                Expected 1 space after "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Expected 1 space before "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Expected 1 space before "=>"; 0 found
                Open

                                 foreach ($data as $key=>$value) {

                Method name "_power" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _power()

                Terminating statement must be indented to the same level as the CASE body
                Open

                            break;

                Expected 1 space after "=>"; 0 found
                Open

                                foreach ($data as $key=>$value) {

                Line exceeds 120 characters; contains 132 characters
                Open

                 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version

                Line indented incorrectly; expected 12 spaces, found 8
                Open

                        default:

                Line indented incorrectly; expected at least 16 spaces, found 12
                Open

                            CommonFunctions::executeProgram("sensors", "", $lines);

                Line indented incorrectly; expected at least 16 spaces, found 12
                Open

                            CommonFunctions::rfts(PSI_APP_ROOT.'/data/lmsensors.txt', $lines);

                Line indented incorrectly; expected 12 spaces, found 8
                Open

                        case 'command':

                Line indented incorrectly; expected 16 spaces, found 17
                Open

                                 foreach ($data as $key=>$value) {

                Line indented incorrectly; expected 12 spaces, found 8
                Open

                        case 'data':

                Closing brace indented incorrectly; expected 17 spaces, found 16
                Open

                                }

                Line indented incorrectly; expected at least 16 spaces, found 12
                Open

                            $this->error->addConfigError('__construct()', '[sensor_lmsensors] ACCESS');

                The method _fans is not named in camelCase.
                Open

                    private function _fans()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                The method _power is not named in camelCase.
                Open

                    private function _power()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                The method _other is not named in camelCase.
                Open

                    private function _other()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                The method _voltage is not named in camelCase.
                Open

                    private function _voltage()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                The method _temperature is not named in camelCase.
                Open

                    private function _temperature()
                    {
                        $applesmc = false;
                        $sname = '';
                        foreach ($this->_lines as $line) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                The method _current is not named in camelCase.
                Open

                    private function _current()
                    {
                        $sname = '';
                        foreach ($this->_lines as $line) {
                            if ((trim($line) !== "") && (strpos($line, ':') === false)) {

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
                    public function get_name() {
                    }
                }

                Source

                There are no issues that match your filters.

                Category
                Status