Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsysinfo/includes/ups/class.ups.inc.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '48', column '30').
Open

        $this->upsinfo = new UPSInfo();
Severity: Minor
Found in phpsysinfo/includes/ups/class.ups.inc.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'PSI_Error' in method '__construct'.
Open

        $this->error = PSI_Error::singleton();
Severity: Minor
Found in phpsysinfo/includes/ups/class.ups.inc.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

abstract class UPS implements PSI_Interface_UPS
Severity: Minor
Found in phpsysinfo/includes/ups/class.ups.inc.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version
Severity: Minor
Found in phpsysinfo/includes/ups/class.ups.inc.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version
Severity: Minor
Found in phpsysinfo/includes/ups/class.ups.inc.php by phpcodesniffer

There are no issues that match your filters.

Category
Status