Function execute has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
public function execute()
{
switch (strtolower(PSI_PLUGIN_HYPERV_ACCESS)) {
case 'command':
if (PSI_OS == 'WINNT') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute()
{
switch (strtolower(PSI_PLUGIN_HYPERV_ACCESS)) {
case 'command':
if (PSI_OS == 'WINNT') {The method execute() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
public function execute()
{
switch (strtolower(PSI_PLUGIN_HYPERV_ACCESS)) {
case 'command':
if (PSI_OS == 'WINNT') {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '45', column '39'). Open
$objLocator = new COM('WbemScripting.SWbemLocator');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'CommonFunctions' in method 'execute'. Open
$result = CommonFunctions::getWMI($wmi, 'MSVM_ComputerSystem', array('InstallDate', 'EnabledState', 'ElementName'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->global_error->addError("HyperV plugin", "Unsupported Windows version");
break;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'CommonFunctions' in method 'execute'. Open
$buffer = CommonFunctions::getWMI($wmic, 'Win32_OperatingSystem', array('Version'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->global_error->addError("HyperV plugin", "Unsupported Windows version");
break;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'CommonFunctions' in method 'execute'. Open
CommonFunctions::rfts(PSI_APP_ROOT."/data/hyperv.txt", $buffer);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using empty try-catch blocks in execute. Open
} catch (Exception $e) {
}- Read upRead up
- Exclude checks
EmptyCatchBlock
Since: 2.7.0
Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.
Example
class Foo {
public function bar()
{
try {
// ...
} catch (Exception $e) {} // empty catch block
}
}Source https://phpmd.org/rules/design.html#emptycatchblock
Similar blocks of code found in 3 locations. Consider refactoring. Open
case 'data':
CommonFunctions::rfts(PSI_APP_ROOT."/data/hyperv.txt", $buffer);
$processes = preg_split("/\n/", $buffer, -1, PREG_SPLIT_NO_EMPTY);
foreach ($processes as $process) {
$ps = preg_split("/[\s]?\|[\s]?/", $process, -1, PREG_SPLIT_NO_EMPTY);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 143.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class HyperV extends PSI_Plugin- Exclude checks
Avoid variables with short names like $ps. Configured minimum length is 3. Open
$ps = preg_split("/[\s]?\|[\s]?/", $process, -1, PREG_SPLIT_NO_EMPTY);- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The property $_filecontent is not named in camelCase. Open
class HyperV extends PSI_Plugin
{
/**
* variable, which holds the content of the command- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
Terminating statement must be indented to the same level as the CASE body Open
break;- Exclude checks
Property name "$_filecontent" should not be prefixed with an underscore to indicate visibility Open
private $_filecontent = array();- Exclude checks
Terminating statement must be indented to the same level as the CASE body Open
break;- Exclude checks
Terminating statement must be indented to the same level as the CASE body Open
break;- Exclude checks
Inline control structures are not allowed Open
if (is_array($result)) foreach ($result as $machine) {- Exclude checks
Line exceeds 120 characters; contains 136 characters Open
$result = CommonFunctions::getWMI($wmi, 'MSVM_ComputerSystem', array('InstallDate', 'EnabledState', 'ElementName'));- Exclude checks
Line exceeds 120 characters; contains 132 characters Open
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
if (PSI_OS == 'WINNT') {- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
}- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
if ($machine['InstallDate'] !== null) {- Exclude checks
Line indented incorrectly; expected at least 32 spaces, found 28 Open
$wmi = $objLocator->ConnectServer('', 'root\virtualization\v2');- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
if ($buffer && isset($buffer[0]) && isset($buffer[0]['Version'])) {- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$result = CommonFunctions::getWMI($wmi, 'MSVM_ComputerSystem', array('InstallDate', 'EnabledState', 'ElementName'));- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$buffer = CommonFunctions::getWMI($wmic, 'Win32_OperatingSystem', array('Version'));- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
}- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$this->global_error->addConfigError("execute()", "[hyperv] ACCESS");- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
case 'command':- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
}- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
if (count($ps) == 2) {- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
} elseif (version_compare($buffer[0]['Version'], "6.0", ">=")) { // minimal windows 2008- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
} else {- Exclude checks
Line indented incorrectly; expected at least 28 spaces, found 24 Open
break;- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
}- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
try {- Exclude checks
Line indented incorrectly; expected 28 spaces, found 24 Open
if (version_compare($buffer[0]['Version'], "6.2", ">=")) { // minimal windows 2012 or windows 8- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
}- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$wmic = $objLocator->ConnectServer('', 'root\CIMv2');- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
}- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
foreach ($processes as $process) {- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
CommonFunctions::rfts(PSI_APP_ROOT."/data/hyperv.txt", $buffer);- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
}- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$processes = preg_split("/\n/", $buffer, -1, PREG_SPLIT_NO_EMPTY);- Exclude checks
Line indented incorrectly; expected at least 32 spaces, found 27 Open
$this->global_error->addError("HyperV plugin", "Unsupported Windows version");- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
case 'data':- Exclude checks
Line indented incorrectly; expected at least 32 spaces, found 28 Open
$wmi = $objLocator->ConnectServer('', 'root\virtualization');- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
if (is_array($result)) foreach ($result as $machine) {- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$ps = preg_split("/[\s]?\|[\s]?/", $process, -1, PREG_SPLIT_NO_EMPTY);- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
}- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
default:- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$objLocator = new COM('WbemScripting.SWbemLocator');- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
} catch (Exception $e) {- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$this->_filecontent[] = array(trim($ps[0]), trim($ps[1]));- Exclude checks
Line indented incorrectly; expected at least 32 spaces, found 27 Open
break;- Exclude checks
Line indented incorrectly; expected at least 28 spaces, found 24 Open
$this->global_error->addError("HyperV plugin", "Unsupported Windows version");- Exclude checks
Line indented incorrectly; expected at least 32 spaces, found 28 Open
$this->_filecontent[] = array($machine['ElementName'], $machine['EnabledState']);- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
} else {- Exclude checks