Sign upLogin

XoopsModules25x/xoopsinfo

View on GitHub
Star
phpsysinfo/plugins/pingtest/class.pingtest.inc.php

Summary

Maintainability
C
1 day
Test Coverage

The method __construct() contains an eval expression.
Open

                $addresses = eval(PSI_PLUGIN_PINGTEST_ADDRESSES);
Severity: Minor
Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

EvalExpression

Since: 0.2

An eval-expression is untestable, a security risk and bad practice. Therefore it should be avoided. Consider to replace the eval-expression with regular code.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            eval('$param = 23;');
        }
    }
}

Source https://phpmd.org/rules/design.html#evalexpression

The method execute() contains an eval expression.
Open

                $addresses = eval(PSI_PLUGIN_PINGTEST_ADDRESSES);
Severity: Minor
Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

EvalExpression

Since: 0.2

An eval-expression is untestable, a security risk and bad practice. Therefore it should be avoided. Consider to replace the eval-expression with regular code.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            eval('$param = 23;');
        }
    }
}

Source https://phpmd.org/rules/design.html#evalexpression

Function __construct has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
Severity: Minor
Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
Severity: Minor
Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php - About 2 hrs to fix

    Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute()
    {
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
                $addresses = eval(PSI_PLUGIN_PINGTEST_ADDRESSES);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __construct() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
    Open

        public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using undefined variables such as '$buffer' which will lead to PHP notices.
    Open

                        if ((strlen($buffer) > 0) && preg_match("/[=<]([\d\.]+)\s*ms/", $buffer, $tmpout)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$buffer' which will lead to PHP notices.
    Open

                    $addresses = preg_split("/\n/", $buffer, -1, PREG_SPLIT_NO_EMPTY);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$buffer' which will lead to PHP notices.
    Open

                        if ((strlen($buffer) > 0) && preg_match("/[=<]([\d\.]+)\s*ms/", $buffer, $tmpout)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$buffer' which will lead to PHP notices.
    Open

                        CommonFunctions::executeProgram("ping".((strpos($address, ':') === false)?'':((PSI_OS !== 'WINNT')?'6':'')), $params." ".$address, $buffer, PSI_DEBUG);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$buffer' which will lead to PHP notices.
    Open

                    CommonFunctions::rfts(PSI_APP_ROOT."/data/pingtest.txt", $buffer);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using static access to class 'CommonFunctions' in method '__construct'.
    Open

                    CommonFunctions::rfts(PSI_APP_ROOT."/data/pingtest.txt", $buffer);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        $params .= " -W 2";
                    }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        $params .= " -w 2000";
                    }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'CommonFunctions' in method '__construct'.
    Open

                        CommonFunctions::executeProgram("ping".((strpos($address, ':') === false)?'':((PSI_OS !== 'WINNT')?'6':'')), $params." ".$address, $buffer, PSI_DEBUG);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $addresses = array(PSI_PLUGIN_PINGTEST_ADDRESSES);
            }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $addresses = array(PSI_PLUGIN_PINGTEST_ADDRESSES);
            }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $params = "-c 1";
                    if (defined('PSI_PLUGIN_PINGTEST_TIMEOUT')) {
                        if (($tout = max(intval(PSI_PLUGIN_PINGTEST_TIMEOUT), 0)) > 0) {
                            $params .= " -W ".$tout;
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid assigning values to variables in if clauses and the like (line '59', column '30').
    Open

        public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '49', column '30').
    Open

        public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);
        if (defined('PSI_PLUGIN_PINGTEST_ADDRESSES') && is_string(PSI_PLUGIN_PINGTEST_ADDRESSES)) {
            if (preg_match(ARRAY_EXP, PSI_PLUGIN_PINGTEST_ADDRESSES)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                case 'data':
                CommonFunctions::rfts(PSI_APP_ROOT."/data/pingtest.txt", $buffer);
                $addresses = preg_split("/\n/", $buffer, -1, PREG_SPLIT_NO_EMPTY);
                foreach ($addresses as $address) {
                    $pt = preg_split("/[\s]?\|[\s]?/", $address, -1, PREG_SPLIT_NO_EMPTY);
    Severity: Major
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php and 2 other locations - About 3 hrs to fix
    phpsysinfo/plugins/hyperv/class.hyperv.inc.php on lines 71..80
    phpsysinfo/plugins/psstatus/class.psstatus.inc.php on lines 77..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class PingTest extends PSI_Plugin
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    The property $_result is not named in camelCase.
    Open

    class PingTest extends PSI_Plugin
{
    /**
     * variable, which holds the content of the command
     * @var array
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The property $_filecontent is not named in camelCase.
    Open

    class PingTest extends PSI_Plugin
{
    /**
     * variable, which holds the content of the command
     * @var array
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    Avoid variables with short names like $pt. Configured minimum length is 3.
    Open

                        $pt = preg_split("/[\s]?\|[\s]?/", $address, -1, PREG_SPLIT_NO_EMPTY);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Terminating statement must be indented to the same level as the CASE body
    Open

                    break;
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Property name "$_result" should not be prefixed with an underscore to indicate visibility
    Open

        private $_result = array();
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Terminating statement must be indented to the same level as the CASE body
    Open

                    break;
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Blank line found at end of control structure
    Open
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Method name "PingTest::address_inarray" is not in camel caps format
    Open

        private function address_inarray($needle, $haystack)
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Terminating statement must be indented to the same level as the CASE body
    Open

                    break;
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Property name "$_filecontent" should not be prefixed with an underscore to indicate visibility
    Open

        private $_filecontent = array();
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

     * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License version 2, or (at your option) any later version
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line exceeds 120 characters; contains 171 characters
    Open

                        CommonFunctions::executeProgram("ping".((strpos($address, ':') === false)?'':((PSI_OS !== 'WINNT')?'6':'')), $params." ".$address, $buffer, PSI_DEBUG);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 28 spaces, found 24
    Open

                            if (($tout = max(intval(PSI_PLUGIN_PINGTEST_TIMEOUT), 0)) > 0) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 20 spaces, found 16
    Open

                    CommonFunctions::rfts(PSI_APP_ROOT."/data/pingtest.txt", $buffer);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        if (defined('PSI_PLUGIN_PINGTEST_TIMEOUT')) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 28 spaces, found 24
    Open

                            $params .= " -w 2000";
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 28 spaces, found 24
    Open

                            $params .= " -W 2";
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 20 spaces, found 16
    Open

                    $addresses = preg_split("/\n/", $buffer, -1, PREG_SPLIT_NO_EMPTY);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    foreach ($addresses as $address) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 28 spaces, found 24
    Open

                            $this->_filecontent[] = array(trim($pt[0]), trim($pt[1]));
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 24 spaces, found 20
    Open

                        $params = "-n 1";
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        } else {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 24 spaces, found 20
    Open

                        $pt = preg_split("/[\s]?\|[\s]?/", $address, -1, PREG_SPLIT_NO_EMPTY);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    if (PSI_OS == 'WINNT') {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 28 spaces, found 24
    Open

                            if (($tout = max(intval(PSI_PLUGIN_PINGTEST_TIMEOUT), 0)) > 0) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 32 spaces, found 28
    Open

                                $params .= " -w ".(1000*$tout);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 20 spaces, found 16
    Open

                    $this->global_error->addConfigError("__construct()", "[pingtest] ACCESS");
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    } else {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 32 spaces, found 28
    Open

                                $params .= " -W ".$tout;
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        if (count($pt) == 2) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 28 spaces, found 24
    Open

                            }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        if ((strlen($buffer) > 0) && preg_match("/[=<]([\d\.]+)\s*ms/", $buffer, $tmpout)) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 12
    Open

                default:
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 24 spaces, found 20
    Open

                        $params = "-c 1";
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 24 spaces, found 20
    Open

                        CommonFunctions::executeProgram("ping".((strpos($address, ':') === false)?'':((PSI_OS !== 'WINNT')?'6':'')), $params." ".$address, $buffer, PSI_DEBUG);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 12
    Open

                case 'data':
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        if (defined('PSI_PLUGIN_PINGTEST_TIMEOUT')) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 12
    Open

                case 'command':
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected at least 28 spaces, found 24
    Open

                            $this->_filecontent[] = array($address, $tmpout[1]);
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 28 spaces, found 24
    Open

                            }
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 24 spaces, found 20
    Open

                        } else {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 16
    Open

                    foreach ($addresses as $address) {
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpcodesniffer

    The method address_inarray is not named in camelCase.
    Open

        private function address_inarray($needle, $haystack)
    {
        foreach ($haystack as $stalk) {
            if ($needle === $stalk[0]) {
                return $stalk[1];
    Severity: Minor
    Found in phpsysinfo/plugins/pingtest/class.pingtest.inc.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status