XoopsModules25x/xoopsinfo

File read_config.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
if (!defined('PSI_CONFIG_FILE')) {
    /**
     * phpSysInfo version
     */

Avoid deeply nested control flow statements.

Open

                    if (@exec('uname -o 2>/dev/null', $unameo) && (sizeof($unameo)>0) && (($unameo0 = trim($unameo[0])) != "")) {
                        define('PSI_UNAMEO', $unameo0);
                    }

Avoid deeply nested control flow statements.

Open

                if ($lang == "") {
                    $lang = 'Unknown';
                }

Avoid deeply nested control flow statements.

Open

                if (!defined('PSI_SYSTEM_CODEPAGE')) {
                    if (file_exists($vtfname = '/sys/module/vt/parameters/default_utf8')
                       && (trim(@file_get_contents($vtfname)) === "1")) {
                            define('PSI_SYSTEM_CODEPAGE', 'UTF-8');
                    } elseif (@exec($matches[1].' locale -k LC_CTYPE 2>/dev/null', $lines)) { //if not overloaded in phpsysinfo.ini

Avoid deeply nested control flow statements.

Open

                    if (!defined('PSI_MODE_POPEN')) { //if not overloaded in phpsysinfo.ini
                        if (!function_exists("proc_open")) { //proc_open function test by executing 'pwd' command
                            define('PSI_MODE_POPEN', true); //use popen() function - no stderr error handling (but with problems with timeout)
                        } else {
                            $out = '';

Avoid deeply nested control flow statements.

Open

                if (!defined('PSI_SYSTEM_LANG') && @exec($matches[1].' locale 2>/dev/null', $lines2)) { //also if not overloaded in phpsysinfo.ini
                    foreach ($lines2 as $line) {
                        if (preg_match('/^LC_MESSAGES="?([^\."@]*)/', $line, $matches2)) {
                            $lang = "";
                            if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {

Avoid deeply nested control flow statements.

Open

                    if (preg_match('/^"?([^\."]*)\.?([^"]*)/', $line, $matches2)) {

                        if (!defined('PSI_SYSTEM_CODEPAGE') && isset($matches2[2]) && !is_null($matches2[2]) && (trim($matches2[2]) != "")) { //also if not overloaded in phpsysinfo.ini
                            define('PSI_SYSTEM_CODEPAGE', $matches2[2]);
                        }

Avoid deeply nested control flow statements.

Open

                if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {
                    if (isset($langdata['Linux']['_'.$lines[0]])) {
                        $lang = $langdata['Linux']['_'.$lines[0]];
                    }
                }

Consider simplifying this complex logical expression.

Open

            if (file_exists($fname = '/etc/sysconfig/i18n')
               || file_exists($fname = '/etc/default/locale')
               || file_exists($fname = '/etc/locale.conf')
               || file_exists($fname = '/etc/sysconfig/language')
               || file_exists($fname = '/etc/profile.d/lang.sh')

Consider simplifying this complex logical expression.

Open

            if (!(defined('PSI_SYSTEM_CODEPAGE') && defined('PSI_SYSTEM_LANG')) //also if both not overloaded in phpsysinfo.ini
               && $contents && (preg_match('/^(LANG="?[^"\n]*"?)/m', $contents, $matches)
               || preg_match('/^RC_(LANG="?[^"\n]*"?)/m', $contents, $matches)
               || preg_match('/^\s*export (LANG="?[^"\n]*"?)/m', $contents, $matches))) {
                if (!defined('PSI_SYSTEM_CODEPAGE')) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        if (!defined('PSI_SYSTEM_LANG')) { //if not overloaded in phpsysinfo.ini
                            $lang = "";
                            if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {
                                if (isset($langdata['Linux']['_'.$matches2[1]])) {
                                    $lang = $langdata['Linux']['_'.$matches2[1]];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (!defined('PSI_SYSTEM_LANG') //if not overloaded in phpsysinfo.ini
                && @exec('defaults read /Library/Preferences/.GlobalPreferences AppleLocale 2>/dev/null', $lines)) {
                $lang = "";
                if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {
                    if (isset($langdata['Linux']['_'.$lines[0]])) {

• Read up
  Read up

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 6 and the first side effect is on line 21.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space before "=>"; 0 found

Open

        foreach ($config as $name=>$group) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after "=>"; 0 found

Open

        foreach ($config as $name=>$group) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space before "=>"; 0 found

Open

            foreach ($group as $param=>$value) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after "=>"; 0 found

Open

            foreach ($group as $param=>$value) {

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

                    if (preg_match('/^"?([^\."]*)\.?([^"]*)/', $line, $matches2)) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 142 characters

Open

                            define('PSI_MODE_POPEN', true); //use popen() function - no stderr error handling (but with problems with timeout)

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 157 characters

Open

                        define($name_prefix.strtoupper($param), 'return '.var_export(preg_split('/\s*,\s*/', trim($value), -1, PREG_SPLIT_NO_EMPTY), 1).';');

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 131 characters

Open

                    } elseif (@exec($matches[1].' locale -k LC_CTYPE 2>/dev/null', $lines)) { //if not overloaded in phpsysinfo.ini

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 145 characters

Open

                if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 127 characters

Open

            if (!(defined('PSI_SYSTEM_CODEPAGE') && defined('PSI_SYSTEM_LANG')) //also if both not overloaded in phpsysinfo.ini

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 134 characters

Open

        if (simplexml_load_string("<A><B><C/></B>\n</A>") !== simplexml_load_string("<A><B><C/></B></A>")) { // json_encode issue test

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 157 characters

Open

                            if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 127 characters

Open

            if (!(defined('PSI_SYSTEM_CODEPAGE') && defined('PSI_SYSTEM_LANG')) //also if both not overloaded in phpsysinfo.ini

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 146 characters

Open

                if (!defined('PSI_SYSTEM_LANG') && @exec($matches[1].' locale 2>/dev/null', $lines2)) { //also if not overloaded in phpsysinfo.ini

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 157 characters

Open

                            if (is_readable(PSI_APP_ROOT.'/data/languages.ini') && ($langdata = @parse_ini_file(PSI_APP_ROOT.'/data/languages.ini', true))) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 129 characters

Open

                    if (@exec('uname -o 2>/dev/null', $unameo) && (sizeof($unameo)>0) && (($unameo0 = trim($unameo[0])) != "")) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 121 characters

Open

                            $descriptorspec = array(0=>array("pipe", "r"), 1=>array("pipe", "w"), 2=>array("pipe", "w"));

• Exclude checks
  • Disable engine
  • Disable check