b_xoopspartners_show accesses the super-global variable $GLOBALS. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_xoopspartners_show accesses the super-global variable $GLOBALS. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_xoopspartners_show accesses the super-global variable $GLOBALS. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Method b_xoopspartners_edit
has 117 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_xoopspartners_edit($options)
{
if (0 == $options[0]) { //put spaces between partners
$chk0no = ' checked';
$chk0yes = '';
Method b_xoopspartners_show
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
Function b_xoopspartners_show
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_xoopspartners_edit
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function b_xoopspartners_edit($options)
{
if (0 == $options[0]) { //put spaces between partners
$chk0no = ' checked';
$chk0yes = '';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The function b_xoopspartners_edit() has 129 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function b_xoopspartners_edit($options)
{
if (0 == $options[0]) { //put spaces between partners
$chk0no = ' checked';
$chk0yes = '';
- Exclude checks
The function b_xoopspartners_edit() has an NPath complexity of 4096. The configured NPath complexity threshold is 200. Open
function b_xoopspartners_edit($options)
{
if (0 == $options[0]) { //put spaces between partners
$chk0no = ' checked';
$chk0yes = '';
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function b_xoopspartners_edit() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
function b_xoopspartners_edit($options)
{
if (0 == $options[0]) { //put spaces between partners
$chk0no = ' checked';
$chk0yes = '';
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function b_xoopspartners_show() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
function b_xoopspartners_show($options)
{
$myts = \MyTextSanitizer::getInstance();
$moduleDirName = basename(dirname(__DIR__));
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '57', column '21'). Open
$criteria = new \CriteriaCompo(new \Criteria('status', 1, '='));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '57', column '40'). Open
$criteria = new \CriteriaCompo(new \Criteria('status', 1, '='));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method b_xoopspartners_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$chk0no = '';
$chk0yes = ' checked';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_xoopspartners_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$criteria->setSort($options[5]);
$criteria->setOrder($options[6]);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_xoopspartners_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$partners['title'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\MyTextSanitizer' in method 'b_xoopspartners_show'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_xoopspartners_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$chk1no = '';
$chk1yes = ' checked';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_xoopspartners_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$chk2no = '';
$chk2yes = ' checked';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\XoopsModules\Xoopspartners\Helper' in method 'b_xoopspartners_show'. Open
$helper = Helper::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$myts'. Open
$myts = \MyTextSanitizer::getInstance();
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
TODO found Open
//@TODO: make display string length a config option
- Exclude checks
Line exceeds 120 characters; contains 123 characters Open
. " <td><input class='right' type='number' name='options[3]' size='5' value='{$options[3]}' min='0'></td>\n"
- Exclude checks
Line exceeds 120 characters; contains 166 characters Open
$form .= " <option value='weight'{$sel}>" . _MB_XOOPSPARTNERS_WEIGHT . "</option>\n" . " </select>\n" . " <select size='1' name='options[6]'>\n";
- Exclude checks
Line exceeds 120 characters; contains 268 characters Open
$form .= " <option value='3'{$sel}>" . _MB_XOOPSPARTNERS_BOTH . "</option>\n" . " </select>\n" . " </td>\n" . " </tr>\n" . " <tr>\n" . ' <td>' . _MB_XOOPSPARTNERS_BSORT . "</td>\n" . " <td>\n" . " <select size='1' name='options[5]'>\n";
- Exclude checks