Sign upLogin

XoopsModules25x/xoopspoll

View on GitHub
Star
class/Common/BlockActionsHandler.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function handleActions has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function handleActions(BlockData $blockData)
    {
        $moduleDirNameUpper = \mb_strtoupper(Helper::getInstance()->getDirname());
        $bid = Request::getInt('bid', 0);
Severity: Minor
Found in class/Common/BlockActionsHandler.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleActions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handleActions(BlockData $blockData)
    {
        $moduleDirNameUpper = \mb_strtoupper(Helper::getInstance()->getDirname());
        $bid = Request::getInt('bid', 0);
Severity: Minor
Found in class/Common/BlockActionsHandler.php - About 1 hr to fix

    Method processOrderBlockAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function processOrderBlockAction(BlockData $blockData)
    {
        $blockData->bid           = Request::getArray('bid', []);
        $blockData->oldtitle      = Request::getArray('oldtitle', [], 'POST');
        $blockData->oldside       = Request::getArray('oldside', [], 'POST');
    Severity: Minor
    Found in class/Common/BlockActionsHandler.php - About 1 hr to fix

      The method handleActions() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public function handleActions(BlockData $blockData)
    {
        $moduleDirNameUpper = \mb_strtoupper(Helper::getInstance()->getDirname());
        $bid = Request::getInt('bid', 0);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->groups         = Request::getArray('groups', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method handleActions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    xoops_confirm(['ok' => 1, 'op' => 'delete', 'bid' => $bid], 'blocksadmin.php', constant('CO_' . $moduleDirNameUpper . '_' . 'DELETE_BLOCK_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
                    xoops_cp_footer();
                }
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->confirm_submit = Request::getCmd('confirm_submit', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->bweight        = Request::getString('bweight', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->weight         = Request::getString('weight', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->bside          = Request::getString('bside', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->bcachetime     = Request::getString('bcachetime', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->options        = Request::getArray('options', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->fct            = Request::getString('fct', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->visible        = Request::getString('visible', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->weight        = Request::getArray('weight', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->side          = Request::getArray('side', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldtitle      = Request::getArray('oldtitle', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Xoopspoll\Helper' in method '__construct'.
      Open

              $this->helper = Helper::getInstance();
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'handleActions'.
      Open

              $bid = Request::getInt('bid', 0);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldgroups     = Request::getArray('oldgroups', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->ok             = Request::getInt('ok', 0, 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->submit         = Request::getString('submit', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->title          = Request::getString('title', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldweight     = Request::getArray('oldweight', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->btitle         = Request::getString('btitle', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldside       = Request::getArray('oldside', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldvisible    = Request::getArray('oldvisible', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldbcachetime = Request::getArray('oldcachetime', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'handleActions'.
      Open

                      $blockData->bid        = Request::getArray('bid', []);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->bmodule        = Request::getArray('bmodule', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->oldbmodule    = Request::getArray('oldbmodule', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->title         = Request::getArray('title', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->submitblock    = Request::getString('submitblock', '', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->bvisible       = Request::getString('bvisible', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processPostData'.
      Open

              $blockData->side           = Request::getString('side', '0', 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method handleActions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $this->helper->redirect('admin/blocksadmin.php', 3, _AM_BLOCK_EDIT_ID_ERROR);
                }
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->visible       = Request::getArray('visible', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->bcachetime    = Request::getArray('bcachetime', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'handleActions'.
      Open

                      $blockData->titleArray = Request::getArray('title', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->bid           = Request::getArray('bid', []);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->bmodule       = Request::getArray('bmodule', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Xmf\Request' in method 'processOrderBlockAction'.
      Open

              $blockData->groups        = Request::getArray('groups', [], 'POST');
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The closing brace for the class must go on the next line after the body
      Open

      }
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpcodesniffer

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Xoopspoll\{
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpcodesniffer

      Line exceeds 120 characters; contains 210 characters
      Open

                      $this->blocksadmin->isBlockCloned($bid, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups, true);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpcodesniffer

      Line exceeds 120 characters; contains 232 characters
      Open

                          xoops_confirm(['ok' => 1, 'op' => 'delete', 'bid' => $bid], 'blocksadmin.php', constant('CO_' . $moduleDirNameUpper . '_' . 'DELETE_BLOCK_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpcodesniffer

      Line exceeds 120 characters; contains 222 characters
      Open

                      $this->blocksadmin->updateBlock($bid, $blockData->btitle, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups);
      Severity: Minor
      Found in class/Common/BlockActionsHandler.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status