Sign upLogin

XoopsModules25x/xoopspoll

View on GitHub
Star
extras/newbb_5x/irmtfan/class/UserLanguage.php

Summary

Maintainability
A
3 hrs
Test Coverage

getUserbar accesses the super-global variable $GLOBALS.
Open

    public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
Severity: Minor
Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getUserbar accesses the super-global variable $GLOBALS.
Open

    public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
Severity: Minor
Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method getUserbar has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
Severity: Major
Found in extras/newbb_5x/irmtfan/class/UserLanguage.php - About 2 hrs to fix

    Function getUserbar has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method getUserbar() has an NPath complexity of 384. The configured NPath complexity threshold is 200.
    Open

        public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getUserbar() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid unused local variables such as '$xoopsModuleConfig'.
    Open

            global $xoopsModuleConfig, $xoopsUser, $isadmin;
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Line exceeds 120 characters; contains 164 characters
    Open

                    'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "','pmlite', 450, 380);",
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpcodesniffer

    Line exceeds 120 characters; contains 164 characters
    Open

                    'link' => "javascript:void window.open('https://edit.yahoo.com/config/send_webmesg?.target=" . $user->getVar('user_yim') . '&.src=pg' . "','new');",
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpcodesniffer

    Line exceeds 120 characters; contains 189 characters
    Open

                    'link' => "javascript:void window.open('aim:goim?screenname=" . $user->getVar('user_aim') . '&amp;message=Hi+' . $user->getVar('user_aim') . '+Are+you+there?' . "','new');",
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpcodesniffer

    Line exceeds 120 characters; contains 129 characters
    Open

                    'link' => "javascript:void window.open('https://members.msn.com?mem=" . $user->getVar('user_msnm') . "','new');",
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpcodesniffer

    Line exceeds 120 characters; contains 142 characters
    Open

                    'link' => "javascript:void window.open('https://wwp.icq.com/scripts/search.dll?to=" . $user->getVar('user_icq') . "','new');",
    Severity: Minor
    Found in extras/newbb_5x/irmtfan/class/UserLanguage.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status