XoopsModules25x/xoopspoll

View on GitHub
extras/newbb_5x/trunk_5_00/polls.php

Summary

Maintainability
F
3 days
Test Coverage

File polls.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Newbb module
 *
 * You may not change or alter any portion of this comment or credits
Severity: Minor
Found in extras/newbb_5x/trunk_5_00/polls.php - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (('add' === $op || 'save' === $op || 'update' === $op)
                && !$topic_obj->getVar('topic_haspoll')
                && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)
                && ($GLOBALS['xoopsUser']->getVar('uid') === $topic_obj->getVar('topic_poster'))) {
                $perm = true;
    Severity: Major
    Found in extras/newbb_5x/trunk_5_00/polls.php - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              foreach ($optionIdArray as $key => $oId) {
                  if (!empty($oId) && ($option_obj = $xpOptHandler->get($oId))) {
                      // existing option object so need to update it
                      $optionTextArray[$key] = trim($optionTextArray[$key]);
                      if ('' === $optionTextArray[$key]) {
      Severity: Major
      Found in extras/newbb_5x/trunk_5_00/polls.php and 3 other locations - About 1 day to fix
      extras/newbb_4x/irmtfan/polls.php on lines 441..474
      extras/newbb_4x/trunk_4_00/polls.php on lines 182..215
      extras/newbb_5x/irmtfan/polls.php on lines 436..469

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 285.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $poll_vars = [
                  'user_id'     => Request::getInt('user_id', $GLOBALS['xoopsUser']->uid(), 'POST'),
                  'question'    => Request::getString('question', null, 'POST'),
                  'description' => Request::getText('description', null, 'POST'),
                  'mail_status' => (Constants::NOTIFICATION_ENABLED === $notify) ? Constants::POLL_NOT_MAILED : Constants::POLL_MAILED,
      Severity: Major
      Found in extras/newbb_5x/trunk_5_00/polls.php and 4 other locations - About 1 day to fix
      admin/main.php on lines 247..261
      extras/newbb_4x/irmtfan/polls.php on lines 413..427
      extras/newbb_4x/trunk_4_00/polls.php on lines 154..168
      extras/newbb_5x/irmtfan/polls.php on lines 408..422

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 256.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (false !== $status) {
                  require_once $GLOBALS['xoops']->path('class/template.php');
                  xoops_template_clear_module_cache($xoopsModule->getVar('mid'));
                  xoops_template_clear_module_cache($xoopspoll->getVar('mid'));
                  // delete comments for this poll
      Severity: Major
      Found in extras/newbb_5x/trunk_5_00/polls.php and 1 other location - About 4 hrs to fix
      extras/newbb_4x/trunk_4_00/polls.php on lines 308..326

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!empty($end_time)) {
                  $timezone = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getVar('timezone') : null;
                  //        $poll_obj->setVar("end_time", userTimeToServerTime(strtotime($end_time), $timezone));
                  //Hack by irmtfan
                  $poll_obj->setVar('end_time', userTimeToServerTime(method_exists('XoopsLocal', 'strtotime') ? XoopsLocal::strtotime($end_time) : strtotime($end_time), $timezone));
      Severity: Major
      Found in extras/newbb_5x/trunk_5_00/polls.php and 1 other location - About 1 hr to fix
      extras/newbb_5x/irmtfan/polls.php on lines 728..735

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $expire_text           = new \XoopsFormText(_MD_POLL_EXPIRATION . '<br><small>' . _MD_POLL_FORMAT . '<br>' . sprintf(_MD_POLL_CURRENTTIME, formatTimestamp(time(), _DATESTRING)) . '</small>', 'end_time', 20, 19, formatTimestamp(time() + $default_poll_duration, _DATESTRING));
      Severity: Major
      Found in extras/newbb_5x/trunk_5_00/polls.php and 1 other location - About 1 hr to fix
      extras/newbb_5x/irmtfan/polls.php on lines 696..696

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              foreach ($option_text as $optxt) {
                  $optxt = trim($optxt);
                  if ('' !== $optxt) {
                      $option_obj = $xpOptHandler->create();
                      $option_obj->setVar('option_text', $optxt);
      Severity: Minor
      Found in extras/newbb_5x/trunk_5_00/polls.php and 1 other location - About 45 mins to fix
      extras/newbb_4x/trunk_4_00/polls.php on lines 268..279

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Line exceeds 120 characters; contains 282 characters
      Open

              $expire_text           = new \XoopsFormText(_MD_POLL_EXPIRATION . '<br><small>' . _MD_POLL_FORMAT . '<br>' . sprintf(_MD_POLL_CURRENTTIME, formatTimestamp(time(), _DATESTRING)) . '</small>', 'end_time', 20, 19, formatTimestamp(time() + $default_poll_duration, _DATESTRING));

      Line exceeds 120 characters; contains 136 characters
      Open

                  redirect_header(Request::getString('HTTP_REFERER', '', 'SERVER'), 2, _MD_ERROROCCURED . ': ' . _MD_POLL_POLLOPTIONS . ' !');

      Line exceeds 120 characters; contains 136 characters
      Open

                  redirect_header(Request::getString('HTTP_REFERER', '', 'SERVER'), 2, _MD_ERROROCCURED . ': ' . _MD_POLL_POLLOPTIONS . ' !');

      Line exceeds 120 characters; contains 154 characters
      Open

              $startTimestamp   = empty($_POST['xu_start_time']) ? ($endTimestamp - Constants::DEFAULT_POLL_DURATION) : userTimeToServerTime($xuStartTimestamp);

      Line exceeds 120 characters; contains 151 characters
      Open

              redirect_header($GLOBALS['xoops']->url("modules/xoopspoll/admin/main.php?op=log&amp;poll_id={$poll_id}"), 2, _MD_LOG_XOOPSPOLL_ADMIN_REDIRECT);

      Line exceeds 120 characters; contains 175 characters
      Open

                  $poll_obj->setVar('end_time', userTimeToServerTime(method_exists('XoopsLocal', 'strtotime') ? XoopsLocal::strtotime($end_time) : strtotime($end_time), $timezone));

      Line exceeds 120 characters; contains 121 characters
      Open

                  $timezone = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getVar('timezone') : null;

      Line exceeds 120 characters; contains 166 characters
      Open

              xoops_confirm(['op' => 'delete_ok', 'topic_id' => $topic_id, 'poll_id' => $poll_id], 'polls.php', sprintf(_MD_POLL_RUSUREDEL, $poll_obj->getVar('question')));

      Line exceeds 120 characters; contains 154 characters
      Open

              $endTimestamp     = empty($_POST['xu_end_time']) ? ($currentTimestamp + Constants::DEFAULT_POLL_DURATION) : userTimeToServerTime($xuEndTimestamp);

      Line exceeds 120 characters; contains 140 characters
      Open

          if ($topicHandler->getPermission($forum_obj, $topic_obj->getVar('topic_status'), 'addpoll')//&& $forum_obj->getVar('allow_polls') == 1 {

      Line exceeds 120 characters; contains 129 characters
      Open

                  'mail_status' => (Constants::NOTIFICATION_ENABLED === $notify) ? Constants::POLL_NOT_MAILED : Constants::POLL_MAILED,

      There are no issues that match your filters.

      Category
      Status