Sign upLogin

XoopsModules25x/xoopspoll

View on GitHub
Star
include/onuninstall.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '42', column '29').
Open

        $criteria     = new \Criteria('topic_haspoll', 0, '>');
Severity: Minor
Found in include/onuninstall.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\XoopsModules\Xoopspoll\Utility' in method 'xoops_module_uninstall_xoopspoll'.
Open

    $success = Utility::setVoteCookie('', '', time() - 3600);
Severity: Minor
Found in include/onuninstall.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$module'.
Open

function xoops_module_pre_uninstall_xoopspoll(\XoopsModule $module): bool
Severity: Minor
Found in include/onuninstall.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$module'.
Open

function xoops_module_uninstall_xoopspoll(\XoopsModule $module): bool
Severity: Minor
Found in include/onuninstall.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $s1. Configured minimum length is 3.
Open

        $s1           = $topicHandler->updateAll('poll_id', 0, $criteria);  // clear any polls associated with forum topic
Severity: Minor
Found in include/onuninstall.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $s2. Configured minimum length is 3.
Open

        $s2           = $topicHandler->updateAll('topic_haspoll', 0, $criteria); // clear haspoll indicator in forum
Severity: Minor
Found in include/onuninstall.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There must be one USE keyword per declaration
Open

use XoopsModules\Xoopspoll\{
Severity: Minor
Found in include/onuninstall.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

        $s1           = $topicHandler->updateAll('poll_id', 0, $criteria);  // clear any polls associated with forum topic
Severity: Minor
Found in include/onuninstall.php by phpcodesniffer

There are no issues that match your filters.

Category
Status