XoopsModules25x/xoopspoll

View on GitHub
include/search.php

Summary

Maintainability
B
5 hrs
Test Coverage

xoopspoll_search accesses the super-global variable $GLOBALS.
Open

function xoopspoll_search($queryArray, mixed $andor, mixed $limit, mixed $offset, $uid): array
{
    $ret = [];
    if (0 === (int)$uid) {
        $pollHandler = Helper::getInstance()->getHandler('Poll');
Severity: Minor
Found in include/search.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function xoopspoll_search has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

function xoopspoll_search($queryArray, mixed $andor, mixed $limit, mixed $offset, $uid): array
{
    $ret = [];
    if (0 === (int)$uid) {
        $pollHandler = Helper::getInstance()->getHandler('Poll');
Severity: Minor
Found in include/search.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xoopspoll_search has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xoopspoll_search($queryArray, mixed $andor, mixed $limit, mixed $offset, $uid): array
{
    $ret = [];
    if (0 === (int)$uid) {
        $pollHandler = Helper::getInstance()->getHandler('Poll');
Severity: Major
Found in include/search.php - About 2 hrs to fix

    Method xoopspoll_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function xoopspoll_search($queryArray, mixed $andor, mixed $limit, mixed $offset, $uid): array
    Severity: Minor
    Found in include/search.php - About 35 mins to fix

      The function xoopspoll_search() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
      Open

      function xoopspoll_search($queryArray, mixed $andor, mixed $limit, mixed $offset, $uid): array
      {
          $ret = [];
          if (0 === (int)$uid) {
              $pollHandler = Helper::getInstance()->getHandler('Poll');
      Severity: Minor
      Found in include/search.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '46', column '28').
      Open

              $criteria->add(new \Criteria('start_time', time(), '<=')); // only show polls that have started
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '45', column '28').
      Open

              $criteria    = new \CriteriaCompo();
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '86', column '32').
      Open

                  $criteria->add(new \Criteria('question', "%{$queryArray[0]}%", 'LIKE'));
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '87', column '32').
      Open

                  $criteria->add(new \Criteria('description', "%{$queryArray[0]}%", 'LIKE'), 'OR');
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '92', column '36').
      Open

                      $criteria->add(new \Criteria('description', "%{$query}%", 'LIKE'), 'OR');
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '91', column '36').
      Open

                      $criteria->add(new \Criteria('question', "%{$query}%", 'LIKE'), $andor);
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '72', column '59').
      Open

                      $tArray       = $topicHandler->getAll(new \Criteria('topic_haspoll', 0, '>'), $tFields, false);
      Severity: Minor
      Found in include/search.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Xoopspoll\{
      Severity: Minor
      Found in include/search.php by phpcodesniffer

      Line exceeds 120 characters; contains 124 characters
      Open

                      $link = $GLOBALS['xoops']->url("modules/newbb/viewtopic.php?topic_id={$pollsWithTopics[$poll['poll_id']]}");
      Severity: Minor
      Found in include/search.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status