Sign upLogin

XoopsModules25x/xoopstube

View on GitHub
Star
admin/upload.php

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (1 === Request::getInt('confirm', '', 'POST')) { // isset($_POST['confirm']) && $_POST['confirm'] == 1) {
            $filetodelete = XOOPS_ROOT_PATH . '/' . Request::getString('uploadpath', '', 'POST') . '/' . Request::getString('videofile', '', 'POST');
            if (file_exists($filetodelete)) {
                chmod($filetodelete, 0666);
                if (@unlink($filetodelete)) {
Severity: Major
Found in admin/upload.php and 1 other location - About 2 hrs to fix
admin/vupload.php on lines 53..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!empty($imgurl)) {
                $indeximage_tray->addElement(new \XoopsFormLabel('', '<br><br><img src="' . XOOPS_URL . '/' . $dirarray[$rootpath] . '/' . $videofile . '" name="image" id="image" alt"">'));
            } else {
                $indeximage_tray->addElement(new \XoopsFormLabel('', '<br><br><img src="' . XOOPS_URL . '/uploads/blank.gif" name="image" id="image" alt="">'));
            }
Severity: Minor
Found in admin/upload.php and 1 other location - About 35 mins to fix
admin/vupload.php on lines 116..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The CASE body must start on the line following the statement
Open

    case 'delfile':
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 189 characters
Open

                $indeximage_tray->addElement(new \XoopsFormLabel('', '<br><br><img src="' . XOOPS_URL . '/' . $dirarray[$rootpath] . '/' . $videofile . '" name="image" id="image" alt"">'));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 149 characters
Open

            $filetodelete = XOOPS_ROOT_PATH . '/' . Request::getString('uploadpath', '', 'POST') . '/' . Request::getString('videofile', '', 'POST');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 160 characters
Open

                $indeximage_tray->addElement(new \XoopsFormLabel('', '<br><br><img src="' . XOOPS_URL . '/uploads/blank.gif" name="image" id="image" alt="">'));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

            echo '<div><b>' . _AM_XOOPSTUBE_VIDEO_FUPLOADPATH . '</b> ' . XOOPS_ROOT_PATH . '/' . $dirarray[$rootpath] . '</div>';
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 155 characters
Open

            $indexImageSelect->setExtra("onchange='showImgSelected(\"image\", \"videofile\", \"" . $dirarray[$rootpath] . '", "", "' . XOOPS_URL . "\")'");
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 138 characters
Open

            Xoopstube\Utility::uploadFiles($_FILES, Request::getString('uploadpath', '', 'POST'), $allowed_mimetypes, 'upload.php', 1, 0);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 138 characters
Open

            if (file_exists(XOOPS_ROOT_PATH . '/' . Request::getString('uploadpath', '', 'POST') . '/' . $_FILES['uploadfile']['name'])) {
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 133 characters
Open

            $graph_array      = Xoopstube\Lists:: getListTypeAsArray(XOOPS_ROOT_PATH . '/' . $dirarray[$rootpath], $type = 'images');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 134 characters
Open

        $iform = new \XoopsThemeForm(_AM_XOOPSTUBE_VIDEO_FUPLOADIMAGETO . $pathlist, 'op', xoops_getenv('SCRIPT_NAME'), 'post', true);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line exceeds 120 characters; contains 127 characters
Open

            echo '<div><b>' . _AM_XOOPSTUBE_VIDEO_FUPLOADURL . '</b> ' . XOOPS_URL . '/' . $dirarray[$rootpath] . '</div><br>';
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $butt_dupct = new \XoopsFormButton('', '', _AM_XOOPSTUBE_BDELETEIMAGE, 'submit');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $dup_tray = new \XoopsFormElementTray('', '');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $butt_dup = new \XoopsFormButton('', '', _AM_XOOPSTUBE_BUPLOAD, 'submit');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $iform->addElement($indeximage_tray);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $butt_dup->setExtra('onclick="this.form.elements.op.value=\'upload\'"');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $iform->addElement(new \XoopsFormFile(_AM_XOOPSTUBE_VIDEO_FUPLOADIMAGE, 'uploadfile', 0));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $dup_tray->addElement(new \XoopsFormHidden('op', 'upload'));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $dup_tray->addElement($butt_dup);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $iform->addElement($dup_tray);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Closing brace indented incorrectly; expected 4 spaces, found 8
Open

        }
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected 16 spaces, found 12
Open

            }
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    if ($rootpath > 0) {
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $iform->addElement(new \XoopsFormHidden('uploadpath', $dirarray[$rootpath]));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $butt_dupct->setExtra('onclick="this.form.elements.op.value=\'delfile\'"');
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $dup_tray->addElement($butt_dupct);
Severity: Minor
Found in admin/upload.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            $iform->addElement(new \XoopsFormHidden('rootnumber', $rootpath));
Severity: Minor
Found in admin/upload.php by phpcodesniffer

There are no issues that match your filters.

Category
Status