Sign upLogin

XoopsModules25x/xoopstube

View on GitHub
Star
class/Common/FileChecker.php

Summary

Maintainability
B
6 hrs
Test Coverage

getFileStatus accesses the super-global variable $_SERVER.
Open

    public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
Severity: Minor
Found in class/Common/FileChecker.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getFileStatus accesses the super-global variable $_SERVER.
Open

    public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
Severity: Minor
Found in class/Common/FileChecker.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method getFileStatus has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
Severity: Minor
Found in class/Common/FileChecker.php - About 1 hr to fix

    Function getFileStatus has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Remove error control operator '@' on line 141.
    Open

        public static function setFilePermissions($target, $mode = 0777)
    {
        $target = \str_replace('..', '', $target);

        return @\chmod($target, (int)$mode);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    Remove error control operator '@' on line 95.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    The method getFileStatus uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $path_status = "<img src='$pathIcon16/0.png' >";
                $path_status .= "$file_path (" . \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_NOTAVAILABLE') . ') ';
            }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method getFileStatus uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $path_status = "<img src='$pathIcon16/0.png' >";
                $path_status .= "$file_path (" . \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_NOTAVAILABLE') . ') ';
                $path_status .= "<form action='" . $_SERVER['SCRIPT_NAME'] . "' method='post'>";
                $path_status .= "<input type='hidden' name='op' value='copyfile'>";
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        case 'copyfile':
        if (\Xmf\Request::hasVar('original_file_path', 'POST')) {
            $original_file_path = $_POST['original_file_path'];
        }
        if (\Xmf\Request::hasVar('file_path', 'POST')) {
    Severity: Major
    Found in class/Common/FileChecker.php and 1 other location - About 4 hrs to fix
    class/Common/DirectoryChecker.php on lines 148..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    The parameter $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $destination_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $original_file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $source_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $file_path is not named in camelCase.
    Open

        public static function fileExists($file_path)
    {
        return \is_file($file_path);
    }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $file1_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $file2_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 37 and the first side effect is on line 28.
    Open

    <?php
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line exceeds 120 characters; contains 170 characters
    Open

                    $path_status .= "<button class='submit' onClick='this.form.submit();'>" . \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_CREATETHEFILE') . '</button>';
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

                    $path_status .= "$file_path (" . \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_NOTAVAILABLE') . ') ';
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

                    $path_status .= "$file_path (" . \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_NOTAVAILABLE') . ') ';
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line exceeds 120 characters; contains 203 characters
    Open

            $msg = FileChecker::copyFile($original_file_path, $file_path) ? \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_FILECOPIED') : \constant('CO_' . $moduleDirNameUpper . '_' . 'FC_FILENOTCOPIED');
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Closing brace indented incorrectly; expected 8 spaces, found 12
    Open

                } else {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } else {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpcodesniffer

    The variable $original_file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $original_file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $source_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file1_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file1_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file2_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file1_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $destination_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file2_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file2_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file1_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file2_path is not named in camelCase.
    Open

        public static function compareFiles($file1_path, $file2_path)
    {
        if (!self::fileExists($file1_path) || !self::fileExists($file2_path)) {
            return false;
        }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $source_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $destination_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $destination_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function fileExists($file_path)
    {
        return \is_file($file_path);
    }
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $original_file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $path_status is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $source_path is not named in camelCase.
    Open

        public static function copyFile($source_path, $destination_path)
    {
        $source_path      = \str_replace('..', '', $source_path);
        $destination_path = \str_replace('..', '', $destination_path);
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $file_path is not named in camelCase.
    Open

        public static function getFileStatus($file_path, $original_file_path = null, $redirectFile = null)
    {
        global $pathIcon16;

        if (empty($file_path)) {
    Severity: Minor
    Found in class/Common/FileChecker.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status