XoopsModules25x/xoopstube

View on GitHub
class/plugins/plugin.tag.php

Summary

Maintainability
A
2 hrs
Test Coverage

xoopstube_tag_iteminfo accesses the super-global variable $GLOBALS.
Open

function xoopstube_tag_iteminfo(&$items)
{
    $moduleDirName = \basename(\dirname(__DIR__));

    if (empty($items) || !is_array($items)) {
Severity: Minor
Found in class/plugins/plugin.tag.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoopstube_tag_iteminfo accesses the super-global variable $GLOBALS.
Open

function xoopstube_tag_iteminfo(&$items)
{
    $moduleDirName = \basename(\dirname(__DIR__));

    if (empty($items) || !is_array($items)) {
Severity: Minor
Found in class/plugins/plugin.tag.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoopstube_tag_iteminfo accesses the super-global variable $GLOBALS.
Open

function xoopstube_tag_iteminfo(&$items)
{
    $moduleDirName = \basename(\dirname(__DIR__));

    if (empty($items) || !is_array($items)) {
Severity: Minor
Found in class/plugins/plugin.tag.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoopstube_tag_iteminfo accesses the super-global variable $GLOBALS.
Open

function xoopstube_tag_iteminfo(&$items)
{
    $moduleDirName = \basename(\dirname(__DIR__));

    if (empty($items) || !is_array($items)) {
Severity: Minor
Found in class/plugins/plugin.tag.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method xoopstube_tag_iteminfo has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xoopstube_tag_iteminfo(&$items)
{
    $moduleDirName = \basename(\dirname(__DIR__));

    if (empty($items) || !is_array($items)) {
Severity: Minor
Found in class/plugins/plugin.tag.php - About 1 hr to fix

    Function xoopstube_tag_iteminfo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$myts'.
    Open

        $myts = \MyTextSanitizer::getInstance();
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused parameters such as '$mid'.
    Open

    function xoopstube_tag_synchronization($mid)
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused local variables such as '$moduleDirName'.
    Open

        $moduleDirName = \basename(\dirname(__DIR__));
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid using static access to class '\MyTextSanitizer' in method 'xoopstube_tag_iteminfo'.
    Open

        $myts = \MyTextSanitizer::getInstance();
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Line exceeds 120 characters; contains 172 characters
    Open

                $sql                     = 'SELECT l.lid, l.cid AS lcid, l.title AS ltitle, l.published, l.cid, l.submitter, l.description, l.item_tag, c.title AS ctitle FROM '
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpcodesniffer

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xoopstube_tag_iteminfo(&$items)
    {
        $moduleDirName = \basename(\dirname(__DIR__));
    
        if (empty($items) || !is_array($items)) {
    Severity: Minor
    Found in class/plugins/plugin.tag.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status