Sign upLogin

YaleSTC/shifts

View on GitHub
Star
app/controllers/users_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method save_import has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def save_import
    if params[:commit]=="Cancel"
      redirect_to import_department_users_path(@department) and return
    end
    @users=params[:users_to_import].collect{|i| params[:user][i]}
Severity: Minor
Found in app/controllers/users_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if @user = User.where(login: params[:user][:login]).first
      if @user.departments.include? @department #if user is already in this department
        flash[:notice] = "This user already exists in this department."
      else
Severity: Minor
Found in app/controllers/users_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    #TODO: prevent params hacking w/ regard to setting roles and login and payrate
    params[:user][:role_ids] ||= []
    @user = User.find(params[:id])
    #store role changes, or else they'll overwrite roles in other departments
Severity: Minor
Found in app/controllers/users_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File users_controller.rb has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class UsersController < ApplicationController
  before_filter :require_admin_or_superuser, except: 'autocomplete'

  def index
    if params[:show_inactive]
Severity: Minor
Found in app/controllers/users_controller.rb - About 2 hrs to fix

    Method update has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update
    #TODO: prevent params hacking w/ regard to setting roles and login and payrate
    params[:user][:role_ids] ||= []
    @user = User.find(params[:id])
    #store role changes, or else they'll overwrite roles in other departments
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 1 hr to fix

      Method autocomplete has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def autocomplete
    @list = []
    classes = params[:classes] || ["User", "Department", "Role"]

    if classes.include?("User")
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save_import has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def save_import
    if params[:commit]=="Cancel"
      redirect_to import_department_users_path(@department) and return
    end
    @users=params[:users_to_import].collect{|i| params[:user][i]}
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 1 hr to fix

        Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
    if @user = User.where(login: params[:user][:login]).first
      if @user.departments.include? @department #if user is already in this department
        flash[:notice] = "This user already exists in this department."
      else
        Severity: Minor
        Found in app/controllers/users_controller.rb - About 1 hr to fix

          Method autocomplete has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def autocomplete
    @list = []
    classes = params[:classes] || ["User", "Department", "Role"]

    if classes.include?("User")
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 1 hr to fix

            Method index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def index
    if params[:show_inactive]
      @users = @department.users
    else
      @users = current_department.active_users.sort_by(&:reverse_name)
            Severity: Minor
            Found in app/controllers/users_controller.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  departments.each do |department|
        if department.name.downcase.include?(params[:q])
          @list << {id: "Department||#{department.id}", name: "Department: #{department.name}"}
            Severity: Minor
            Found in app/controllers/users_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/users_controller.rb on lines 290..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  roles.each do |role|
        if role.name.downcase.include?(params[:q])
          @list << {id: "Role||#{role.id}", name: "Role: #{role.name}"}
            Severity: Minor
            Found in app/controllers/users_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/users_controller.rb on lines 282..284

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status