Sign upLogin

YaleSTC/shifts

View on GitHub
Star
app/helpers/payforms_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method payform_update_button has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def payform_update_button
    if @payform.submitted
      if current_user.is_admin_of?(@payform.department)
        if @payform.approved && !@payform.printed
          link_to "<span><strong>Print</strong></span>".html_safe, print_payform_path(@payform), class: "button", onclick: "this.blur();"
Severity: Minor
Found in app/helpers/payforms_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method payform_skip_button has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def payform_skip_button
    if @payform.submitted and !@payform.approved and !@payform.printed
      if current_user.is_admin_of?(@payform.department)
         if !@payform.skipped
           link_to "<span><strong>Skip and go to next</strong></span>".html_safe, skip_payform_path(@payform), class: "button", onclick: "this.blur();"
Severity: Minor
Found in app/helpers/payforms_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status