Sign upLogin

YaleSTC/shifts

View on GitHub
Star
app/models/user.rb

Summary

Maintainability
D
2 days
Test Coverage

Class User has 41 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  acts_as_authentic do |options|
    options.maintain_sessions false
  end
Severity: Minor
Found in app/models/user.rb - About 5 hrs to fix

    File user.rb has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'net/ldap'
require 'rails_extensions'
require 'memoist'

class User < ActiveRecord::Base
    Severity: Minor
    Found in app/models/user.rb - About 3 hrs to fix

      Method import has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.import(file)
    results = {successes: [], failures: []}
    CSV.foreach(file.path, headers: true) do |row|
      attrs = row.to_hash
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.import(file)
    results = {successes: [], failures: []}
    CSV.foreach(file.path, headers: true) do |row|
      attrs = row.to_hash
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

        Method detailed_stats has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def detailed_stats(start_date, end_date)
    shifts_set = shifts.on_days(start_date, end_date).active
    detailed_stats = {}

    shifts_set.each do |s|
        Severity: Minor
        Found in app/models/user.rb - About 1 hr to fix

          Method detailed_stats has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def detailed_stats(start_date, end_date)
    shifts_set = shifts.on_days(start_date, end_date).active
    detailed_stats = {}

    shifts_set.each do |s|
          Severity: Minor
          Found in app/models/user.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def detailed_stats(start_date, end_date)
    shifts_set = shifts.on_days(start_date, end_date).active
    detailed_stats = {}

    shifts_set.each do |s|
          Severity: Major
          Found in app/models/user.rb and 1 other location - About 2 hrs to fix
          app/models/location.rb on lines 121..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def summary_stats(start_date, end_date)
    shifts_set = shifts.on_days(start_date, end_date).active
    summary_stats = {}

    summary_stats[:start_date] = start_date
          Severity: Major
          Found in app/models/user.rb and 1 other location - About 1 hr to fix
          app/models/location.rb on lines 107..118

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status