Sign upLogin

YaleSTC/shifts

View on GitHub
Star
app/models/user_profile_entry.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method prepare_form_helpers has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def prepare_form_helpers
    if display_type == "text_field"
      return ["user_profile_entries[#{id}]", :content, {value: content}]
    elsif display_type == "picture_link"
      return ["user_profile_entries[#{id}]", :content, {value: content}]
Severity: Minor
Found in app/models/user_profile_entry.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return options.map{|v| ["user_profile_entries[#{id}]", :content, v, content==v ? {checked: true} : {}]}
Severity: Major
Found in app/models/user_profile_entry.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return options.map{|v| ["user_profile_entries[#{id}]", v]}
    Severity: Major
    Found in app/models/user_profile_entry.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return options.map{|v| ["user_profile_entries[#{id}]", v, chosen.include?(v) ? {checked: true} : {}]}
      Severity: Major
      Found in app/models/user_profile_entry.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return ["user_profile_entries[#{id}]", :content, options.map{|opt| [opt, opt]}, {selected: content}]
        Severity: Major
        Found in app/models/user_profile_entry.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status