Sign upLogin

YaleSTC/shifts

View on GitHub
Star
setup/gui_setup.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method smtp has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def smtp
    @@delivery_method = 'smtp'
    @main_box = stack width: '100%' do
      inscription link("Start Over", click: '/')
      title "SMTP Settings", align: 'center'
Severity: Minor
Found in setup/gui_setup.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authentication has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def authentication
    stack width: '100%' do
      inscription link("Start Over", click: '/')
      title "CAS Settings", align: 'center'
      @main_stack = stack {
Severity: Minor
Found in setup/gui_setup.rb - About 1 hr to fix

    Method smtp has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def smtp
    @@delivery_method = 'smtp'
    @main_box = stack width: '100%' do
      inscription link("Start Over", click: '/')
      title "SMTP Settings", align: 'center'
    Severity: Minor
    Found in setup/gui_setup.rb - About 1 hr to fix

      Method writefiles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def writefiles(delivery_method, mail_settings, auth_settings, using_cas)
    File.rename('config/environment.rb', 'config/environment.rb.backup')

    newtext=File.open('config/environment.rb.backup','r').collect.join()
      Severity: Minor
      Found in setup/gui_setup.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def hash_to_string(hash, brackets)
    if hash.nil?
      " "
    elsif brackets
      "{\n"+hash.collect{|k,v| ":#{k} => \"#{v}\","}.join("\n").chomp(',')+"\n}\n"
      Severity: Minor
      Found in setup/gui_setup.rb and 1 other location - About 55 mins to fix
      setup/setup.rb on lines 3..10

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status