YetiForceCompany/YetiForceCRM

View on GitHub
app/Conditions/QueryFields/IntegerField.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class '\App\Purifier' in method 'operatorA'.
Open

        $value = \App\Purifier::decodeHtml($this->value);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $ev. Configured minimum length is 3.
Open

                $ev = explode($exo, $value);

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * Auto operator, it allows you to use formulas: >10 <40, >1, <7.

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach (static::$extendedOperators as $exo) {

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string[] List of extended operators

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorA(): array

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

                $condition[] = [$exo, $this->getColumnName(), (int) $ev[1]];

Spaces must be used to indent lines; tabs are not allowed
Open

            if (false !== strpos($value, $exo)) {

Spaces must be used to indent lines; tabs are not allowed
Open

                $ev = explode($exo, $value);

Spaces must be used to indent lines; tabs are not allowed
Open

                $conditionFound = true;

Spaces must be used to indent lines; tabs are not allowed
Open

    use \App\Conditions\QueryTraits\Comparison;

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public static $extendedOperators = ['>=', '<=', '<', '>'];

Spaces must be used to indent lines; tabs are not allowed
Open

    use \App\Conditions\QueryTraits\ComparisonField;

Spaces must be used to indent lines; tabs are not allowed
Open

                $value = str_replace($exo . (int) $ev[1], '', $value);

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return array

Spaces must be used to indent lines; tabs are not allowed
Open

        $value = \App\Purifier::decodeHtml($this->value);

Spaces must be used to indent lines; tabs are not allowed
Open

        $conditionFound = false;

Spaces must be used to indent lines; tabs are not allowed
Open

        $condition = ['and'];

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getOperator(): string

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$conditionFound) {

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorNy(): array

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        return 'a' === $this->operator ? 'e' : $this->operator;

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorY(): array

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        return [$this->getColumnName() => null];

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return array

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

            return parent::operatorE();

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

        return $condition;

Spaces must be used to indent lines; tabs are not allowed
Open

     * Is empty operator.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return array

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        return ['not', [$this->getColumnName() => null]];

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

     * Is not empty operator.

There are no issues that match your filters.

Category
Status