Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/Conditions/RecordFields/PicklistField.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class '\App\RecordStatus' in method 'operatorRo'.
Open

        return ($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\RecordStatus' in method 'operatorRc'.
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED)));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\RecordStatus' in method 'operatorRo'.
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName()), \App\RecordStatus::RECORD_STATE_OPEN);
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\RecordStatus' in method 'operatorRc'.
Open

        return !(($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Argument 1 (moduleName) is false but \App\RecordStatus::getFieldName() takes string defined at /code/app/RecordStatus.php:406
Open

        return ($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phan

Argument 1 (moduleName) is false but \App\RecordStatus::getStates() takes string defined at /code/app/RecordStatus.php:113
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName()), \App\RecordStatus::RECORD_STATE_OPEN);
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phan

Argument 1 (moduleName) is false but \App\RecordStatus::getFieldName() takes string defined at /code/app/RecordStatus.php:406
Open

        return !(($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phan

Argument 1 (moduleName) is false but \App\RecordStatus::getStates() takes string defined at /code/app/RecordStatus.php:113
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED)));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phan

Argument 3 (strict) is 1 but \in_array() takes bool
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName()), \App\RecordStatus::RECORD_STATE_OPEN);
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phan

Spaces must be used to indent lines; tabs are not allowed
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName()), \App\RecordStatus::RECORD_STATE_OPEN);
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return !(($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return bool
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorRc()
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return \in_array($this->getValue(), explode('##', $this->value));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Record open operator.
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return bool
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return ($fieldName = \App\RecordStatus::getFieldName($this->recordModel->getModule()->getName()))
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return !\in_array($this->getValue(), explode('##', $this->value));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Line exceeds 120 characters; contains 170 characters
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName()), \App\RecordStatus::RECORD_STATE_OPEN);
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Record closed operator.
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorRo()
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Line exceeds 120 characters; contains 173 characters
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED)));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorE(): bool
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function operatorN(): bool
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        && \in_array($this->recordModel->get($fieldName), \App\RecordStatus::getStates($this->recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED)));
Severity: Minor
Found in app/Conditions/RecordFields/PicklistField.php by phpcodesniffer

There are no issues that match your filters.

Category
Status