app/Controller/Traits/RecordSettings.php
Avoid using static access to class '\Vtiger_Link_Model' in method 'getRecordLinks'. Open
Open
$links[] = \Vtiger_Link_Model::getInstanceFromValues($recordLink);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \App\Controller\Traits\RecordSettings::set Open
Open
$this->set($fieldName, $fieldModel->getDBValue($value));- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::get Open
Open
return $this->get('url');- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::getEditViewUrl Open
Open
'linkdata' => ['url' => $this->getEditViewUrl()],- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
return \App\Db::getInstance()->createCommand()- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::get Open
Open
return $this->get('id');- Exclude checks
Return type of getRecordLinks() is undeclared type \App\Controller\Traits\Vtiger_Link_Model[] Open
Open
public function getRecordLinks(): array- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::getFieldInstanceByName Open
Open
$fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::getModule Open
Open
->delete($this->getModule()->baseTable, ['id' => $this->getId()])- Exclude checks
Call to undeclared method \App\Controller\Traits\RecordSettings::getModule Open
Open
foreach ($this->getModule()->getFormFields() as $fieldName => $fieldInfo) {- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
Open
public function setDataFromRequest(\App\Request $request): void
{
foreach ($this->getModule()->getFormFields() as $fieldName => $fieldInfo) {
if ($request->has($fieldName)) {
$value = $request->getByType($fieldName, $fieldInfo['purifyType']);- Read upRead up
modules/Settings/MeetingServices/models/Record.php on lines 149..159
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $request->getByType($fieldName, $fieldInfo['purifyType']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->set($fieldName, $fieldModel->getDBValue($value));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'BTN_RECORD_EDIT',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'fas fa-trash-alt',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to delete the current record model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('id');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links[] = \Vtiger_Link_Model::getInstanceFromValues($recordLink);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('url');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get record links.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-sm btn-primary js-edit-record-modal',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkdata' => ['url' => $this->getEditViewUrl()],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_DELETE_RECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($request->has($fieldName)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Sets data from request.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($this->getModule()->getFormFields() as $fieldName => $fieldInfo) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel->validate($value, true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'yfi yfi-full-editing-view',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->delete($this->getModule()->baseTable, ['id' => $this->getId()])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getRecordLinks(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function delete(): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getId()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => "javascript:Settings_Vtiger_List_Js.deleteById('{$this->getId()}')",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
] as $recordLink) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $links;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Vtiger_Link_Model[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-sm btn-danger text-white',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \App\Db::getInstance()->createCommand()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function setDataFromRequest(\App\Request $request): void- Exclude checks