sendHttpHeader accesses the super-global variable $_SERVER.
Open

    public function sendHttpHeader(): void
    {
        header("content-disposition: attachment; filename=\"{$this->getFileName()}\"");
        header("content-type: {$this->getExportContentType()}; charset=UTF-8");
        header('expires: Mon, 31 Dec 2000 00:00:00 GMT');

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

sendHttpHeader accesses the super-global variable $_SERVER.
Open

    public function sendHttpHeader(): void
    {
        header("content-disposition: attachment; filename=\"{$this->getFileName()}\"");
        header("content-type: {$this->getExportContentType()}; charset=UTF-8");
        header('expires: Mon, 31 Dec 2000 00:00:00 GMT');

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function `sanitizeInventoryValues` has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function sanitizeInventoryValues(array $inventoryRow, array $inventoryFields): array
    {
        $inventoryEntries = [];
        foreach ($inventoryFields as $columnName => $field) {
            $value = $inventoryRow[$columnName];

Found in app/Export/Records.php - About 4 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Class "Records" has 21 methods, which is greater than 20 authorized. Split it into smaller classes.
Open

abstract class Records extends \App\Base

Found in app/Export/Records.php by sonar-php

Read up
Read up
Exclude checks
- Disable engine
- Disable check

A class that grows too much tends to aggregate too many responsibilities and inevitably becomes harder to understand and therefore to maintain. Above a specific threshold, it is strongly advised to refactor the class into smaller ones which focus on well defined topics.

Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed.
Open

    public function sanitizeInventoryValues(array $inventoryRow, array $inventoryFields): array

Found in app/Export/Records.php by sonar-php

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Cognitive Complexity

The class Records has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.
Open

abstract class Records extends \App\Base
{
    /** @var int Data export in a format that can be imported later */
    public const EXPORT_FORMAT = 0;

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Missing class import via use statement (line '177', column '15').
Open

                throw new \App\Exceptions\IllegalValue("ERR_FIELD_NOT_FOUND||{$relatedFieldName}");

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '77', column '35').
Open

        $instance->queryGenerator = new \App\QueryGenerator($moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid assigning values to variables in if clauses and the like (line '155', column '9').
Open

    public function loadFieldsFromCvId(int $cvId): void
    {
        foreach (\App\CustomView::getInstance($this->moduleName)->getColumnsListByCvid($cvId) as $fieldInfo) {
            ['field_name' => $relatedFieldName, 'module_name' => $relatedModule, 'source_field_name' => $referenceField] = $fieldInfo;
            $cvFieldData = $referenceField ? "{$relatedFieldName}:{$relatedModule}:{$referenceField}" : $relatedFieldName;

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open

                $header = \App\Language::translate(\App\Purifier::decodeHtml($fieldModel->getFieldLabel()), $this->moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Record' in method 'sanitizeInventoryValues'.
Open

                    $recordModule = \App\Record::getType($value);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Fields\SharedOwner' in method 'getDisplayValue'.
Open

            $value = implode(',', \App\Fields\SharedOwner::getById($recordId));

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method setField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $result = false;
        }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\App\Purifier' in method 'getAllModuleFieldsAsHeaders'.
Open

                $header = \App\Language::translate(\App\Purifier::decodeHtml($fieldModel->getFieldLabel()), $this->moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Json' in method 'sanitizeInventoryValues'.
Open

                        $valueParam = \App\Json::encode($valueNewData);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Record' in method 'sanitizeInventoryValues'.
Open

                    $displayValue = \App\Record::getLabel($value);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getFileName'.
Open

        return \App\Utils::sanitizeSpecialChars(\App\Purifier::decodeHtml(\App\Language::translate($this->moduleName, $this->moduleName))) . ".{$this->fileExtension}";

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Language' in method 'getFileName'.
Open

        return \App\Utils::sanitizeSpecialChars(\App\Purifier::decodeHtml(\App\Language::translate($this->moduleName, $this->moduleName))) . ".{$this->fileExtension}";

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getAllModuleFieldsAsHeaders'.
Open

                $headers[] = 'Inventory::' . \App\Language::translate(\App\Purifier::decodeHtml($field->get('label')), $this->moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Vtiger_Module_Model' in method 'getInstance'.
Open

        $instance->moduleInstance = \Vtiger_Module_Model::getInstance($moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Fields\File' in method 'getExportContentType'.
Open

        return \App\Fields\File::getMimeContentType($this->getFileName());

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getHeaders'.
Open

                    $this->headers[] = \App\Purifier::decodeHtml($label);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open

                $headers[] = 'Inventory::' . \App\Language::translate(\App\Purifier::decodeHtml($field->get('label')), $this->moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Vtiger_Loader' in method 'getInstance'.
Open

        $modelClassName = \Vtiger_Loader::getComponentClassName('Model', $componentName, $moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method sanitizeValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $valuesToReturn = $this->getDataInExportFormat($recordValues);
        }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getHeaders uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                foreach ($this->fields as $fieldModel) {
                    $label = $fieldModel->getFullLabelTranslation($this->moduleInstance);
                    $this->headers[] = \App\Purifier::decodeHtml($label);
                }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open

                    $header = \App\Language::translate(\App\Purifier::decodeHtml($fieldModel->getBlockName()), $this->moduleName) . '::' . $header;

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Utils' in method 'getFileName'.
Open

        return \App\Utils::sanitizeSpecialChars(\App\Purifier::decodeHtml(\App\Language::translate($this->moduleName, $this->moduleName))) . ".{$this->fileExtension}";

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Config' in method 'getSupportedFileFormats'.
Open

        return \App\Config::module($moduleName, 'EXPORT_SUPPORTED_FILE_FORMATS') ?? [

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getAllModuleFieldsAsHeaders'.
Open

                    $header = \App\Language::translate(\App\Purifier::decodeHtml($fieldModel->getBlockName()), $this->moduleName) . '::' . $header;

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Vtiger_Inventory_Model' in method 'getAllModuleFieldsAsHeaders'.
Open

            $inventoryModel = \Vtiger_Inventory_Model::getInstance($this->moduleName);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method sanitizeInventoryValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $value = '';
                    }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\App\Fields\Currency' in method 'sanitizeInventoryValues'.
Open

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'.
Open

            $returnValue = \App\Purifier::decodeHtml($returnValue);

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getInstance uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $componentName = 'ExportTo' . ucfirst($exportType);
        }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\App\Config' in method 'getAllModuleFieldsAsHeaders'.
Open

        $exportBlockName = \App\Config::component('Export', 'BLOCK_NAME');

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method sanitizeInventoryValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $value = '';
                }

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Define a constant instead of duplicating this literal "label" 4 times.
Open

            if (($fieldModel = $this->setField($cvFieldData)) && $fieldInfo['label']) {

Found in app/Export/Records.php by sonar-php

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "source_field_name" 6 times.
Open

            ['field_name' => $relatedFieldName, 'module_name' => $relatedModule, 'source_field_name' => $referenceField] = $fieldInfo;

Found in app/Export/Records.php by sonar-php

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Rename "$headers" which has the same name as the field declared at line 39.
Open

        $headers = [];

Found in app/Export/Records.php by sonar-php

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

CERT, DCL51-J. - Do not shadow or obscure identifiers in subscopes

Avoid unused local variables such as '$dbType'.
Open

                foreach ($field->getCustomColumn() as $columnName => $dbType) {

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$dbType'.
Open

            foreach ($field->getCustomColumn() as $customColumnName => $dbType) {

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$rowData'.
Open

    public function getDisplayValue(\Vtiger_Field_Model $fieldModel, $value, int $recordId, array $rowData, $length = 65000)

Found in app/Export/Records.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method `set` from undeclared class `\App\Export\Vtiger_Field_Model`
Open

                $fieldModel->set('label', $fieldInfo['label']);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Reference to undeclared property `\App\Export\Records->queryGenerator`
Open

        return $this->queryGenerator;

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `set` from undeclared class `\App\Export\Vtiger_Field_Model`
Open

                $fieldModel->set('isLabelCustomized', true);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Return type of `getInstance()` is undeclared type `\self`
Open

    public static function getInstance(string $moduleName, string $exportType = 'csv')

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Return type of `getQueryGenerator()` is undeclared type `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

    public function getQueryGenerator(): \App\QueryGenerator

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `setFields` from undeclared class `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

            $queryGenerator->setFields(['id'])->addCondition('id', 0, 'e');

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to deprecated function `\Vtiger_Field_Model::getFieldLabel()` defined at `/code/modules/Vtiger/models/Field.php:215`
Open

                $header = \App\Language::translate(\App\Purifier::decodeHtml($fieldModel->getFieldLabel()), $this->moduleName);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `clearFields` from undeclared class `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

        $queryGenerator->clearFields()->setLimit($this->limit);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Saw an @param annotation for `moduleName,` but the param list of `function getFileName() : string` is empty
Open

     * @param string $moduleName

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `__construct` from undeclared class `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

        $instance->queryGenerator = new \App\QueryGenerator($moduleName);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Assigning `int` to property but `\App\Export\Records->format` is `bool`
Open

    protected $format = self::EXPORT_FORMAT;

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `createQuery` from undeclared class `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

        return $queryGenerator->createQuery();

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Return type of `setField()` is undeclared type `\App\Export\Vtiger_Field_Model`
Open

    public function setField(string $fieldName)

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Call to method `setField` from undeclared class `\App\QueryGenerator` (Did you mean class \Tests\App\QueryGenerator)
Open

            $queryGenerator->setField($fieldName);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Argument 1 `(recordId)` is `string` but `\App\Record::getType()` takes `int` defined at `/code/app/Record.php:279`
Open

                    $recordModule = \App\Record::getType($value);

Found in app/Export/Records.php by phan

Exclude checks
- Disable engine
- Disable check

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (\in_array($field->getType(), ['Name', 'Reference'])) {
                $value = trim($value);
                if (!empty($value)) {
                    $recordModule = \App\Record::getType($value);
                    $displayValue = \App\Record::getLabel($value);

Found in app/Export/Records.php and 1 other location - About 3 hrs to fix

Read up
Read up

modules/Vtiger/models/ExportToXml.php on lines 101..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

YetiForceCompany/YetiForceCRM

Summary

Maintainability

Test Coverage

sendHttpHeader accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

sendHttpHeader accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

Function sanitizeInventoryValues has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

The class Records has an overall complexity of 71 which is very high. The configured complexity threshold is 50. Open

File Records.php has 264 lines of code (exceeds 250 allowed). Consider refactoring. Open

Records has 21 functions (exceeds 20 allowed). Consider refactoring. Open

Method sanitizeInventoryValues has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open

Function getAllModuleFieldsAsHeaders has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function setField has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Method getDisplayValue has 5 arguments (exceeds 4 allowed). Consider refactoring. Open

Function getHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

The method sanitizeInventoryValues() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open

CyclomaticComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Class "Records" has 21 methods, which is greater than 20 authorized. Split it into smaller classes. Open

Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed. Open

See

The class Records has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. Open

CouplingBetweenObjects

Since: 1.1.0

Example

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Missing class import via use statement (line '177', column '15'). Open

MissingImport

Since: 2.7.0

Example

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '77', column '35'). Open

MissingImport

Since: 2.7.0

Example

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid assigning values to variables in if clauses and the like (line '155', column '9'). Open

IfStatementAssignment

Since: 2.7.0

Example

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Record' in method 'sanitizeInventoryValues'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Fields\SharedOwner' in method 'getDisplayValue'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method setField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open

ElseExpression

sendHttpHeader accesses the super-global variable $_SERVER.
Open

sendHttpHeader accesses the super-global variable $_SERVER.
Open

Function `sanitizeInventoryValues` has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

The class Records has an overall complexity of 71 which is very high. The configured complexity threshold is 50.
Open

File `Records.php` has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

`Records` has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

Method `sanitizeInventoryValues` has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Function `getAllModuleFieldsAsHeaders` has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

Function `setField` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

Method `getDisplayValue` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

Function `getHeaders` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

The method sanitizeInventoryValues() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

Class "Records" has 21 methods, which is greater than 20 authorized. Split it into smaller classes.
Open

Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed.
Open

The class Records has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.
Open

Missing class import via use statement (line '177', column '15').
Open

Missing class import via use statement (line '77', column '35').
Open

Avoid assigning values to variables in if clauses and the like (line '155', column '9').
Open

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open

Avoid using static access to class '\App\Record' in method 'sanitizeInventoryValues'.
Open

Avoid using static access to class '\App\Fields\SharedOwner' in method 'getDisplayValue'.
Open

The method setField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid using static access to class '\App\Purifier' in method 'getAllModuleFieldsAsHeaders'.
Open

Avoid using static access to class '\App\Json' in method 'sanitizeInventoryValues'.
Open

Avoid using static access to class '\App\Record' in method 'sanitizeInventoryValues'.
Open

Avoid using static access to class '\App\Purifier' in method 'getFileName'.
Open

Avoid using static access to class '\App\Language' in method 'getFileName'.
Open

Avoid using static access to class '\App\Purifier' in method 'getAllModuleFieldsAsHeaders'.
Open

Avoid using static access to class '\Vtiger_Module_Model' in method 'getInstance'.
Open

Avoid using static access to class '\App\Fields\File' in method 'getExportContentType'.
Open

Avoid using static access to class '\App\Purifier' in method 'getHeaders'.
Open

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open

Avoid using static access to class '\Vtiger_Loader' in method 'getInstance'.
Open

The method sanitizeValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

The method getHeaders uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid using static access to class '\App\Language' in method 'getAllModuleFieldsAsHeaders'.
Open