modules/Accounts/models/Record.php
Avoid using static access to class 'CRMEntity' in method 'getAccountHierarchy'. Open
Open
$focus = CRMEntity::getInstance($this->getModuleName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Record_Model' in method 'getAccountHierarchy'. Open
Open
$recordModel = Vtiger_Record_Model::getCleanInstance('Accounts');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \CRMEntity::getAccountHierarchy Open
Open
$hierarchy = $focus->getAccountHierarchy($this->getId());- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Accounts_Record_Model extends Vtiger_Record_Model- Exclude checks
The class Accounts_Record_Model is not named in CamelCase. Open
Open
class Accounts_Record_Model extends Vtiger_Record_Model
{
/**
* Function returns the details of Accounts Hierarchy.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$link = $accountInfo[0]['data'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($matches)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordModel->setId($accountId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getAccountHierarchy()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Line exceeds 120 characters; contains 156 characters Open
Open
$hierarchy['entries'][$accountId][0]['data'] = ($dashes[0] ?? '') . '<a href=' . $recordModel->getDetailViewUrl() . '>' . $name[2] . '</a>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
preg_match('/<a href="+/', $link, $matches);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$hierarchy['entries'][$accountId][0]['data'] = ($dashes[0] ?? '') . '<a href=' . $recordModel->getDetailViewUrl() . '>' . $name[2] . '</a>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $hierarchy;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$focus = CRMEntity::getInstance($this->getModuleName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($hierarchy['entries'] as $accountId => $accountInfo) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function returns the details of Accounts Hierarchy.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordModel = Vtiger_Record_Model::getCleanInstance('Accounts');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
preg_match('/[.\s]+/', $link, $dashes);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$hierarchy = $focus->getAccountHierarchy($this->getId());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
preg_match('/<a(.*)>(.*)<\\/a>/i', $link, $name);- Exclude checks
Class name "Accounts_Record_Model" is not in camel caps format Open
Open
class Accounts_Record_Model extends Vtiger_Record_Model- Exclude checks