Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Accounts/relations/GetCampaigns.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Missing class import via use statement (line '23', column '22').
Open

                ['crmid' => (new \App\Db\Query())->select(['contactid'])->from('vtiger_contactdetails')->where(['parentid' => $sourceRecordId])]
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '33', column '13').
Open

        if (!(new \App\Db\Query())->from(self::TABLE_NAME)->where($data)->exists()) {
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Define a constant instead of duplicating this literal "crmid" 3 times.
Open

                ['crmid' => $sourceRecordId],
Severity: Critical
Found in modules/Accounts/relations/GetCampaigns.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Call to undeclared method \App\Db\Query::from
Open

        if (!(new \App\Db\Query())->from(self::TABLE_NAME)->where($data)->exists()) {
Severity: Critical
Found in modules/Accounts/relations/GetCampaigns.php by phan

Call to undeclared method \App\Db::createCommand
Open

        return (bool) App\Db::getInstance()->createCommand()->delete(self::TABLE_NAME, ['and',
Severity: Critical
Found in modules/Accounts/relations/GetCampaigns.php by phan

Call to undeclared method \App\Db\Query::select
Open

                ['crmid' => (new \App\Db\Query())->select(['contactid'])->from('vtiger_contactdetails')->where(['parentid' => $sourceRecordId])]
Severity: Critical
Found in modules/Accounts/relations/GetCampaigns.php by phan

Call to undeclared method \App\Db::createCommand
Open

            $result = (bool) App\Db::getInstance()->createCommand()->insert(self::TABLE_NAME, $data)->execute();
Severity: Critical
Found in modules/Accounts/relations/GetCampaigns.php by phan

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function create(int $sourceRecordId, int $destinationRecordId): bool
    {
        $result = false;
        $data = ['campaignid' => $destinationRecordId, 'crmid' => $sourceRecordId];
        if (!(new \App\Db\Query())->from(self::TABLE_NAME)->where($data)->exists()) {
Severity: Major
Found in modules/Accounts/relations/GetCampaigns.php and 2 other locations - About 1 hr to fix
modules/Campaigns/relations/GetCampaigns.php on lines 46..56
modules/Campaigns/relations/GetCampaignsRecords.php on lines 46..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Accounts_GetCampaigns_Relation extends Campaigns_GetCampaigns_Relation
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

The class Accounts_GetCampaigns_Relation is not named in CamelCase.
Open

class Accounts_GetCampaigns_Relation extends Campaigns_GetCampaigns_Relation
{
    /** {@inheritdoc} */
    public function delete(int $sourceRecordId, int $destinationRecordId): bool
    {
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

            ['campaignid' => $destinationRecordId],
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ['crmid' => $sourceRecordId],
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $result = false;
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $data['campaignrelstatusid'] = 1;
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Line exceeds 120 characters; contains 144 characters
Open

                ['crmid' => (new \App\Db\Query())->select(['contactid'])->from('vtiger_contactdetails')->where(['parentid' => $sourceRecordId])]
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            ]
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!(new \App\Db\Query())->from(self::TABLE_NAME)->where($data)->exists()) {
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $data = ['campaignid' => $destinationRecordId, 'crmid' => $sourceRecordId];
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        ])->execute();
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ['crmid' => (new \App\Db\Query())->select(['contactid'])->from('vtiger_contactdetails')->where(['parentid' => $sourceRecordId])]
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function delete(int $sourceRecordId, int $destinationRecordId): bool
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            ['or',
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function create(int $sourceRecordId, int $destinationRecordId): bool
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $result = (bool) App\Db::getInstance()->createCommand()->insert(self::TABLE_NAME, $data)->execute();
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return (bool) App\Db::getInstance()->createCommand()->delete(self::TABLE_NAME, ['and',
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $result;
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

Class name "Accounts_GetCampaigns_Relation" is not in camel caps format
Open

class Accounts_GetCampaigns_Relation extends Campaigns_GetCampaigns_Relation
Severity: Minor
Found in modules/Accounts/relations/GetCampaigns.php by phpcodesniffer

There are no issues that match your filters.

Category
Status