Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Assets/crons/Renewal.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Missing class import via use statement (line '20', column '17').
Open

        $query = (new App\Db\Query())->select(['vtiger_assets.assetsid'])->from('vtiger_assets')->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_assets.assetsid')->where(['vtiger_crmentity.deleted' => 0])->andWhere(['or', ['assets_renew' => $renewal], ['assets_renew' => null]]);
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Vtiger_Record_Model' in method 'process'.
Open

            $recordModel = Vtiger_Record_Model::getInstanceById($recordId, 'Assets');
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \Vtiger_Record_Model::updateRenewal
Open

            $recordModel->updateRenewal();
Severity: Critical
Found in modules/Assets/crons/Renewal.php by phan

Call to undeclared method \App\Db\Query::select
Open

        $query = (new App\Db\Query())->select(['vtiger_assets.assetsid'])->from('vtiger_assets')->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_assets.assetsid')->where(['vtiger_crmentity.deleted' => 0])->andWhere(['or', ['assets_renew' => $renewal], ['assets_renew' => null]]);
Severity: Critical
Found in modules/Assets/crons/Renewal.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Assets_Renewal_Cron extends \App\CronHandler
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

The class Assets_Renewal_Cron is not named in CamelCase.
Open

class Assets_Renewal_Cron extends \App\CronHandler
{
    /** {@inheritdoc} */
    public function process()
    {
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel = Vtiger_Record_Model::getInstanceById($recordId, 'Assets');
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Line exceeds 120 characters; contains 295 characters
Open

        $query = (new App\Db\Query())->select(['vtiger_assets.assetsid'])->from('vtiger_assets')->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_assets.assetsid')->where(['vtiger_crmentity.deleted' => 0])->andWhere(['or', ['assets_renew' => $renewal], ['assets_renew' => null]]);
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $dataReader = $query->createCommand()->query();
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        while ($recordId = $dataReader->readColumn(0)) {
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel->updateRenewal();
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $dataReader->close();
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process()
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $query = (new App\Db\Query())->select(['vtiger_assets.assetsid'])->from('vtiger_assets')->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_assets.assetsid')->where(['vtiger_crmentity.deleted' => 0])->andWhere(['or', ['assets_renew' => $renewal], ['assets_renew' => null]]);
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $renewal = ['PLL_PLANNED', 'PLL_WAITING_FOR_RENEWAL', ''];
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

Class name "Assets_Renewal_Cron" is not in camel caps format
Open

class Assets_Renewal_Cron extends \App\CronHandler
Severity: Minor
Found in modules/Assets/crons/Renewal.php by phpcodesniffer

There are no issues that match your filters.

Category
Status