Avoid unused local variables such as '$icon'. Open
foreach ($this->getFieldsIcon() as $fieldName => $icon) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
/**
* RecordPopover model class for Calendar.
*
* @package Model- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 174.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Calendar_RecordPopover_Model extends Vtiger_RecordPopover_Model- Exclude checks
The class Calendar_RecordPopover_Model is not named in CamelCase. Open
class Calendar_RecordPopover_Model extends Vtiger_RecordPopover_Model
{
/** {@inheritdoc} */
public function getFields(): array
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getFields(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$summaryFields = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getFieldsIcon(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($this->getFieldsIcon() as $fieldName => $icon) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'taskpriority' => 'fas fa-exclamation-circle', 'activitystatus' => 'fas fa-question-circle',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkextend' => '', 'link' => '', 'process' => '', 'subprocess' => '', 'state' => 'far fa-star',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'meeting_url' => 'AdditionalIcon-VideoConference'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$summaryFields[$fieldName] = $fieldModel;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return ['date_start' => 'far fa-clock', 'due_date' => 'far fa-clock', 'location' => 'fas fa-globe',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'visibility' => 'fas fa-eye', 'assigned_user_id' => 'fas fa-user',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldsModel = $this->recordModel->getModule()->getFields();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($fieldModel && $fieldModel->isViewableInDetailView() && !$this->recordModel->isEmpty($fieldName)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $summaryFields;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldModel = $fieldsModel[$fieldName] ?? '';- Exclude checks
Class name "Calendar_RecordPopover_Model" is not in camel caps format Open
class Calendar_RecordPopover_Model extends Vtiger_RecordPopover_Model- Exclude checks