modules/Calendar/views/ActivityState.php
Avoid using static access to class '\App\Mail' in method 'getLinks'. Open
Open
if ($this->record->isEditable() && \App\Mail::checkInternalMailClient()) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Link_Model' in method 'getLinks'. Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues([
'linklabel' => 'LBL_SEND_CALENDAR',
'linkdata' => ['url' => "index.php?module={$this->record->getModuleName()}&view=SendInvitationModal&record={$this->record->getId()}"],
'linkicon' => 'yfi-send-invitation',
'linkclass' => 'js-show-modal mt-1 mr-1',- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Reference to undeclared property \Calendar_ActivityState_View->record Open
Open
if ($this->record->isEditable() && \App\Mail::checkInternalMailClient()) {- Exclude checks
Reference to undeclared property \Calendar_ActivityState_View->record Open
Open
'linkdata' => ['url' => "index.php?module={$this->record->getModuleName()}&view=SendInvitationModal&record={$this->record->getId()}"],- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Calendar_ActivityState_View extends Calendar_ActivityStateModal_View- Exclude checks
The class Calendar_ActivityState_View is not named in CamelCase. Open
Open
class Calendar_ActivityState_View extends Calendar_ActivityStateModal_View
{
/** {@inheritdoc} */
protected function getTpl()
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'Calendar/ActivityState.tpl';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_SEND_CALENDAR',- Exclude checks
Line exceeds 120 characters; contains 150 characters Open
Open
'linkdata' => ['url' => "index.php?module={$this->record->getModuleName()}&view=SendInvitationModal&record={$this->record->getId()}"],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'yfi-send-invitation',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $links;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected function getTpl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkdata' => ['url' => "index.php?module={$this->record->getModuleName()}&view=SendInvitationModal&record={$this->record->getId()}"],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'js-show-modal mt-1 mr-1',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getLinks(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->record->isEditable() && \App\Mail::checkInternalMailClient()) {- Exclude checks
Class name "Calendar_ActivityState_View" is not in camel caps format Open
Open
class Calendar_ActivityState_View extends Calendar_ActivityStateModal_View- Exclude checks