modules/Competition/models/DetailView.php
Avoid using static access to class 'Users_Privileges_Model' in method 'getDetailViewRelatedLinks'. Open
Open
$userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Argument 1 (mixed) is 'OpenStreetMap' but \Users_Privileges_Model::hasModulePermission() takes int defined at /code/modules/Users/models/Privileges.php:101 Open
Open
if ($userPrivilegesModel->hasModulePermission('OpenStreetMap')) {- Exclude checks
Class extends undeclared class \Vtiger_DetailView_Model Open
Open
class Competition_DetailView_Model extends Vtiger_DetailView_Model- Exclude checks
Call to undeclared method \Competition_DetailView_Model::getRecord Open
Open
'linkurl' => $this->getRecord()->getDetailViewUrl() . '&mode=showOpenStreetMap',- Exclude checks
Reference to undeclared class \Vtiger_DetailView_Model Open
Open
$relatedLinks = parent::getDetailViewRelatedLinks();- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Competition_DetailView_Model extends Vtiger_DetailView_Model- Exclude checks
The class Competition_DetailView_Model is not named in CamelCase. Open
Open
class Competition_DetailView_Model extends Vtiger_DetailView_Model
{
/** {@inheritdoc} */
public function getDetailViewRelatedLinks()
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($userPrivilegesModel->hasModulePermission('OpenStreetMap')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDetailViewRelatedLinks()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$relatedLinks = parent::getDetailViewRelatedLinks();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => $this->getRecord()->getDetailViewUrl() . '&mode=showOpenStreetMap',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'DETAILVIEWTAB',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => '',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $relatedLinks;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$relatedLinks[] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_MAP',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Competition_DetailView_Model" is not in camel caps format Open
Open
class Competition_DetailView_Model extends Vtiger_DetailView_Model- Exclude checks