Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Contacts/ConfigTemplate.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Define a constant instead of duplicating this literal "description" 3 times.
Open

        'description' => 'Columns visible in Contacts hierarchy [$label => $columnName]'
Severity: Critical
Found in modules/Contacts/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "default" 3 times.
Open

        'default' => [],
Severity: Critical
Found in modules/Contacts/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Count Contacts in hierarchy',
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    'COLUMNS_IN_HIERARCHY' => [
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => [],
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Columns visible in Contacts hierarchy [$label => $columnName]'
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => true,
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'validation' => '\App\Validator::bool',
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ]
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ],
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Max depth of hierarchy',
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    'COUNT_IN_HIERARCHY' => [
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'validation' => '\App\Validator::naturalNumber'
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'sanitization' => '\App\Purifier::bool'
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    'MAX_HIERARCHY_DEPTH' => [
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => 50,
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ],
Severity: Minor
Found in modules/Contacts/ConfigTemplate.php by phpcodesniffer

There are no issues that match your filters.

Category
Status