Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Documents/models/DetailView.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method getDetailViewLinks has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getDetailViewLinks(array $linkParams): array
    {
        $linkModelList = parent::getDetailViewLinks($linkParams);
        $recordModel = $this->getRecord();
        if (!$recordModel->isReadOnly()) {
Severity: Minor
Found in modules/Documents/models/DetailView.php - About 1 hr to fix

    Function getDetailViewLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getDetailViewLinks(array $linkParams): array
    {
        $linkModelList = parent::getDetailViewLinks($linkParams);
        $recordModel = $this->getRecord();
        if (!$recordModel->isReadOnly()) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method getDetailViewLinks() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function getDetailViewLinks(array $linkParams): array
    {
        $linkModelList = parent::getDetailViewLinks($linkParams);
        $recordModel = $this->getRecord();
        if (!$recordModel->isReadOnly()) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using static access to class 'Vtiger_Link_Model' in method 'getDetailViewLinks'.
    Open

                    $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
                    'linktype' => 'DETAIL_VIEW_BASIC',
                    'linklabel' => 'LBL_DOWNLOAD_FILE',
                    'linkurl' => $recordModel->getDownloadFileURL(),
                    'linkicon' => 'fas fa-download',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Users_Privileges_Model' in method 'getDetailViewLinks'.
    Open

                $currentUserModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Link_Model' in method 'getDetailViewLinks'.
    Open

                $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
                'linktype' => 'DETAIL_VIEW_BASIC',
                'linklabel' => 'LBL_CHECK_FILE_INTEGRITY',
                'linkurl' => $recordModel->checkFileIntegrityURL(),
                'linkicon' => 'fas fa-check',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Config' in method 'getDetailViewRelatedLinks'.
    Open

                'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getDetailViewRelatedLinks'.
    Open

                'related' => \App\Json::encode(Documents_Record_Model::getReferenceModuleByDocId($recordModel->getId())),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getDetailViewRelatedLinks'.
    Open

                'linklabel' => \App\Language::translate('LBL_RELATIONS', $recordModel->getModuleName()),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getDetailViewLinks'.
    Open

                        'linklabel' => \App\Language::translate('LBL_EMAIL_FILE_AS_ATTACHMENT', 'Documents'),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Documents_Record_Model' in method 'getDetailViewRelatedLinks'.
    Open

                'related' => \App\Json::encode(Documents_Record_Model::getReferenceModuleByDocId($recordModel->getId())),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Link_Model' in method 'getDetailViewLinks'.
    Open

                    $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
                    'linktype' => 'DETAIL_VIEW_BASIC',
                    'linklabel' => \App\Language::translate('LBL_EMAIL_FILE_AS_ATTACHMENT', 'Documents'),
                    'linkhref' => true,
                    'linktarget' => '_blank',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Config' in method 'getDetailViewLinks'.
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype') && $currentUserModel->hasModulePermission('OSSMail') && App\Config::main('isActiveSendingMails')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "linklabel" 4 times.
    Open

                        'linklabel' => 'LBL_DOWNLOAD_FILE',
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "btn-outline-dark btn-sm" 3 times.
    Open

                        'linkclass' => 'btn-outline-dark btn-sm',
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "linktype" 4 times.
    Open

                        'linktype' => 'DETAIL_VIEW_BASIC',
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "linkurl" 4 times.
    Open

                        'linkurl' => $recordModel->getDownloadFileURL(),
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "linkicon" 4 times.
    Open

                        'linkicon' => 'fas fa-download',
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "linkclass" 3 times.
    Open

                        'linkclass' => 'btn-outline-dark btn-sm',
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "DETAIL_VIEW_BASIC" 6 times.
    Open

                    $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Class extends undeclared class \Vtiger_DetailView_Model
    Open

    class Documents_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by phan

    Reference to undeclared class \Vtiger_DetailView_Model
    Open

            $relatedLinks = parent::getDetailViewRelatedLinks();
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by phan

    Reference to undeclared class \Vtiger_DetailView_Model
    Open

            $linkModelList = parent::getDetailViewLinks($linkParams);
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by phan

    Call to undeclared method \Documents_DetailView_Model::getRecord
    Open

            $recordModel = $this->getRecord();
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by phan

    Call to undeclared method \Documents_DetailView_Model::getRecord
    Open

            $recordModel = $this->getRecord();
    Severity: Critical
    Found in modules/Documents/models/DetailView.php by phan

    Argument 1 (mixed) is 'OSSMail' but \Users_Privileges_Model::hasModulePermission() takes int defined at /code/modules/Users/models/Privileges.php:101
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype') && $currentUserModel->hasModulePermission('OSSMail') && App\Config::main('isActiveSendingMails')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Documents_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    The class Documents_DetailView_Model is not named in CamelCase.
    Open

    class Documents_DetailView_Model extends Vtiger_DetailView_Model
{
    /** {@inheritdoc} */
    public function getDetailViewLinks(array $linkParams): array
    {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel = $this->getRecord();
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $relatedLinks[] = [
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkclass' => 'btn-outline-dark btn-sm',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkclass' => 'btn-outline-dark btn-sm',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'linktype' => 'DETAILVIEWTAB',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linklabel' => 'LBL_DOWNLOAD_FILE',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkicon' => 'fas fa-envelope',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linktarget' => '_blank',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'linkKey' => 'LBL_RECORD_SUMMARY',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $currentUserModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $linkModelList = parent::getDetailViewLinks($linkParams);
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linktype' => 'DETAIL_VIEW_BASIC',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'linkclass' => 'btn-outline-dark btn-sm',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linklabel' => \App\Language::translate('LBL_EMAIL_FILE_AS_ATTACHMENT', 'Documents'),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'linklabel' => \App\Language::translate('LBL_RELATIONS', $recordModel->getModuleName()),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype') && $currentUserModel->hasModulePermission('OSSMail') && App\Config::main('isActiveSendingMails')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getDetailViewLinks(array $linkParams): array
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'linktype' => 'DETAIL_VIEW_BASIC',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ]);
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linktype' => 'DETAIL_VIEW_BASIC',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Line exceeds 120 characters; contains 137 characters
    Open

                        'linkurl' => 'index.php?module=OSSMail&view=Compose&type=new&crmModule=Documents&crmRecord=' . $recordModel->getId(),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel = $this->getRecord();
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkurl' => $recordModel->getDownloadFileURL(),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'linkicon' => 'fas fa-check',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Line exceeds 120 characters; contains 229 characters
    Open

                if ($recordModel->get('filestatus') && $recordModel->get('filename') && 'I' === $recordModel->get('filelocationtype') && $currentUserModel->hasModulePermission('OSSMail') && App\Config::main('isActiveSendingMails')) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $relatedLinks;
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $linkModelList;
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $relatedLinks = parent::getDetailViewRelatedLinks();
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'linkicon' => '',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'related' => \App\Json::encode(Documents_Record_Model::getReferenceModuleByDocId($recordModel->getId())),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showDocumentRelations',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$recordModel->isReadOnly()) {
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkhref' => true,
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkurl' => 'index.php?module=OSSMail&view=Compose&type=new&crmModule=Documents&crmRecord=' . $recordModel->getId(),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkicon' => 'fas fa-download',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ]);
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'linklabel' => 'LBL_CHECK_FILE_INTEGRITY',
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'linkurl' => $recordModel->checkFileIntegrityURL(),
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getDetailViewRelatedLinks()
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $linkModelList['DETAIL_VIEW_BASIC'][] = Vtiger_Link_Model::getInstanceFromValues([
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ]);
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    Class name "Documents_DetailView_Model" is not in camel caps format
    Open

    class Documents_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Minor
    Found in modules/Documents/models/DetailView.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status