Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Documents/views/Detail.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function preProcess(App\Request $request, $display = true)
Severity: Minor
Found in modules/Documents/views/Detail.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\App\Layout\Icon' in method 'preProcess'.
Open

        $fileIcon = \App\Layout\Icon::getIconByFileType($this->record->getRecord()->get('filetype'));
Severity: Minor
Found in modules/Documents/views/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Documents_Record_Model' in method 'showDocumentRelations'.
Open

        $data = Documents_Record_Model::getReferenceModuleByDocId($recordId);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \Documents_Detail_View::exposeMethod
Open

        $this->exposeMethod('showDocumentRelations');
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Call to undeclared method \Documents_Detail_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Call to undeclared method \Documents_Detail_View::getViewer
Open

        $viewer = $this->getViewer($request);
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Class extends undeclared class \Vtiger_Detail_View
Open

class Documents_Detail_View extends Vtiger_Detail_View
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Reference to undeclared class \Vtiger_Detail_View
Open

        parent::__construct();
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Call to undeclared method \Documents_Detail_View::showModuleDetailView
Open

        return $this->showModuleDetailView($request);
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Reference to undeclared class \Vtiger_Detail_View
Open

        parent::preProcess($request);
Severity: Critical
Found in modules/Documents/views/Detail.php by phan

Reference to undeclared property \Documents_Detail_View->record
Open

        $fileIcon = \App\Layout\Icon::getIconByFileType($this->record->getRecord()->get('filetype'));
Severity: Minor
Found in modules/Documents/views/Detail.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Documents_Detail_View extends Vtiger_Detail_View
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

The class Documents_Detail_View is not named in CamelCase.
Open

class Documents_Detail_View extends Vtiger_Detail_View
{
    /** {@inheritdoc} */
    public function __construct()
    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('RECORDID', $recordId);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('EXTENSION_ICON', $fileIcon);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::preProcess($request);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $viewer->view('DetailViewDocumentRelations.tpl', $moduleName, true);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->exposeMethod('showDocumentRelations');
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return false;
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function showDocumentRelations(App\Request $request)
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $data = Documents_Record_Model::getReferenceModuleByDocId($recordId);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('DATA', $data);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $this->showModuleDetailView($request);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('MODULE_NAME', $moduleName);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function __construct()
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::__construct();
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $fileIcon = \App\Layout\Icon::getIconByFileType($this->record->getRecord()->get('filetype'));
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function showModuleBasicView(App\Request $request)
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordId = $request->getInteger('record');
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function preProcess(App\Request $request, $display = true)
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('NO_SUMMARY', true);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function isAjaxEnabled($recordModel)
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('LIMIT', 0);
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

Class name "Documents_Detail_View" is not in camel caps format
Open

class Documents_Detail_View extends Vtiger_Detail_View
Severity: Minor
Found in modules/Documents/views/Detail.php by phpcodesniffer

There are no issues that match your filters.

Category
Status