modules/EmailTemplates/models/Record.php
Define a constant instead of duplicating this literal "sys_name" 3 times. Open
Open
return $this->isEmpty('sys_name') && parent::privilegeToDelete();- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class EmailTemplates_Record_Model extends Vtiger_Record_Model- Exclude checks
The class EmailTemplates_Record_Model is not named in CamelCase. Open
Open
class EmailTemplates_Record_Model extends Vtiger_Record_Model
{
/** {@inheritdoc} */
public function privilegeToDelete()
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->isEmpty('sys_name') && parent::privilegeToMoveToTrash();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function privilegeToArchive()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function privilegeToDelete()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->isEmpty('sys_name') && parent::privilegeToDelete();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function privilegeToMoveToTrash()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->isEmpty('sys_name') && parent::privilegeToArchive();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Class name "EmailTemplates_Record_Model" is not in camel caps format Open
Open
class EmailTemplates_Record_Model extends Vtiger_Record_Model- Exclude checks